Skip to content

live555: 2023.11.30 -> 2024.02.23 #291395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2024
Merged

live555: 2023.11.30 -> 2024.02.23 #291395

merged 2 commits into from
Mar 1, 2024

Conversation

AndersonTorres
Copy link
Member

Description of changes

I need to automate this somehow.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres marked this pull request as ready for review February 25, 2024 18:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 25, 2024
IogaMaster
IogaMaster approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@IogaMaster IogaMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review has been done with warden, please report any issues!

Packages built

✅ live555

✅ live555

nix-info -m

  • system: "x86_64-linux"
  • host os: Linux 6.1.77, NixOS, 24.05 (Uakari), 24.05.20240216.5863c27
  • multi-user?: yes
  • sandbox: relaxed
  • version: nix-env (Nix) 2.19.3
  • nixpkgs: /etc/nix/inputs/nixpkgs

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 25, 2024
@AndersonTorres
Copy link
Member Author

@IogaMaster does warden test passthru.tests?

@IogaMaster
Copy link
Contributor

@IogaMaster does warden test passthru.tests?

No, although it would be a great idea!

@IogaMaster IogaMaster mentioned this pull request Feb 25, 2024
Open
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 26, 2024
@marsam marsam merged commit 8beb456 into NixOS:master Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@IogaMaster IogaMaster IogaMaster approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndersonTorres @IogaMaster @marsam @delroth