Skip to content

FerretDB document defaults, PostgreSQL default URL, disable telemetry #288493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2025
Merged

FerretDB document defaults, PostgreSQL default URL, disable telemetry #288493

merged 3 commits into from
Jan 19, 2025

Conversation

minijackson
Copy link
Member

Description of changes

  • Move the default settings into options, so that they are documented in the options list
  • set a default value for the PostgreSQL URL, to provide a nice default if the end user wants to use the PostgreSQL backend
  • Disable telemetry by default

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @JulienMalka @camillemndn

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 13, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 13, 2024
@minijackson minijackson force-pushed the ferretdb-document-defaults branch from ff7ba3b to e5fe078 Compare May 13, 2024 11:32
@minijackson
Copy link
Member Author

Friendly ping: @JulienMalka @camillemndn

@AlekSi
Copy link
Contributor

AlekSi commented Jul 31, 2024

FerretDB developer there. Why disable telemetry by default?

@minijackson
Copy link
Member Author

@AlekSi hey! It's kind of an unwritten rule inside of nixpkgs to disable telemetry by default. Some of our users expect it.

@JulienMalka
Copy link
Member

Running the sqlite test, I get:
The option nodes.machine.services.ferretdb.settings' is used but not defined.`

@minijackson minijackson force-pushed the ferretdb-document-defaults branch 2 times, most recently from e391c28 to 4485e82 Compare October 25, 2024 09:36
@minijackson minijackson force-pushed the ferretdb-document-defaults branch from 4485e82 to 808cabf Compare January 14, 2025 09:33
@minijackson
nixos/ferretdb: move default settings to options
ccd19c4 
so that they are documented in the options list
@minijackson
nixos/ferretdb: set default value for PostgreSQL URL
3b3764d 
provides a nice default if the end user wants to use the PostgreSQL
backend
@minijackson
nixos/ferretdb: disable telemetry by default
08f1820
@minijackson minijackson force-pushed the ferretdb-document-defaults branch from 808cabf to 08f1820 Compare January 14, 2025 09:39
@minijackson
Copy link
Member Author

@JulienMalka done, thanks!

JulienMalka
JulienMalka approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@JulienMalka JulienMalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

@JulienMalka JulienMalka merged commit e5ad45c into NixOS:master Jan 19, 2025
25 of 27 checks passed
@AlekSi
Copy link
Contributor

AlekSi commented Feb 10, 2025

@AlekSi hey! It's kind of an unwritten rule inside of nixpkgs to disable telemetry by default. Some of our users expect it.

It is ironic to see mongosh being in a better position than FerretDB.

@yuyuyureka yuyuyureka mentioned this pull request May 12, 2025
Closed
13 tasks
@minijackson minijackson deleted the ferretdb-document-defaults branch June 23, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienMalka JulienMalka JulienMalka approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@minijackson @AlekSi @JulienMalka @FliegendeWurst @SigmaSquadron