Skip to content

afterglow-cursors-recolored: init at 0-unstable-2023-10-04 #284617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2024
Merged

afterglow-cursors-recolored: init at 0-unstable-2023-10-04 #284617

merged 1 commit into from
Feb 13, 2024

Conversation

D3vil0p3r
Copy link
Member

Description of changes

afterglow-cursors-recolored: init at unstable-2023-10-04

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@D3vil0p3r D3vil0p3r marked this pull request as ready for review January 28, 2024 21:47
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3350

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 28, 2024
h7x4
h7x4 reviewed Jan 29, 2024
View reviewed changes
h7x4
h7x4 reviewed Jan 29, 2024
View reviewed changes
h7x4
h7x4 reviewed Jan 29, 2024
View reviewed changes
@D3vil0p3r D3vil0p3r changed the title afterglow-cursors-recolored: init at unstable-2023-10-04 afterglow-cursors-recolored: init at 0-unstable-2023-10-04 Jan 29, 2024
@D3vil0p3r D3vil0p3r requested review from h7x4 and NickCao January 29, 2024 19:40
@geri1701 geri1701 self-requested a review February 3, 2024 09:31
@geri1701
Copy link
Member

geri1701 commented Feb 3, 2024

Result of nixpkgs-review pr 284617 run on x86_64-linux 1

1 package built:
  • afterglow-cursors-recolored

h7x4
h7x4 reviewed Feb 10, 2024
View reviewed changes
@D3vil0p3r D3vil0p3r requested a review from h7x4 February 10, 2024 16:20
h7x4
h7x4 reviewed Feb 10, 2024
View reviewed changes
@D3vil0p3r D3vil0p3r requested a review from h7x4 February 10, 2024 16:30
@D3vil0p3r D3vil0p3r requested a review from shard77 February 11, 2024 13:42
shard77
shard77 approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@shard77 shard77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geri1701 geri1701 added the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Feb 13, 2024
@mkg20001 mkg20001 merged commit 96786a3 into NixOS:master Feb 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request Feb 13, 2024
Merged
1 task
@D3vil0p3r D3vil0p3r deleted the patch-4 branch February 13, 2024 22:41
This was referenced Aug 9, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h7x4 h7x4 h7x4 approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@NickCao NickCao Awaiting requested review from NickCao

+2 more reviewers

@geri1701 geri1701 geri1701 approved these changes

@shard77 shard77 shard77 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@D3vil0p3r @nixos-discourse @geri1701 @h7x4 @shard77 @mkg20001