Skip to content

direwolf: make various buildInputs optional #258056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2023
Merged

direwolf: make various buildInputs optional #258056

merged 3 commits into from
Sep 29, 2023

Conversation

sarcasticadmin
Copy link
Member

@sarcasticadmin sarcasticadmin commented Sep 29, 2023 •
edited
Loading

Description of changes

direwolf only depends on a cmake, alsa-lib, udev(https://github.com/wb2osz/direwolf/tree/1.6#linux---using-git-clone-recommended) and should have each of its additional dependencies marked as options (gpsd, hamlib).

Adding extraScripts option to exclude various scripts that are more of examples of direwolf capabilities vs required for using the tool.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lasandell September 29, 2023 16:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 29, 2023
@sarcasticadmin
direwolf: set hamlib, gpsd, and extraScripts as optional
d70fb08 
direwolf includes a set of extra scripts which showcase various
capabilities of the pkg. However, they depend on languages that are not
critical to building direwolf itself.
@sarcasticadmin
direwolf: add maintainer sarcasticadmin
d514277
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 29, 2023
@FRidh FRidh merged commit ae95a37 into NixOS:master Sep 29, 2023
@sarcasticadmin sarcasticadmin mentioned this pull request May 12, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewCroughan MatthewCroughan MatthewCroughan approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@Kranzes Kranzes Awaiting requested review from Kranzes

@lasandell lasandell Awaiting requested review from lasandell

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarcasticadmin @MatthewCroughan @delroth @FRidh