listmonk: 2.2.0 -> 2.5.1 #250843
Merged
listmonk: 2.2.0 -> 2.5.1 #250843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was impossible to package further versions before because listmonk upstream was using a very EOL Go version. I was waiting for upstream to bump this, but it didn't happen, so I take the matters in my hand. Hopefully, the upstream PR will be accepted.
Previously, the transactional template was in id=2. It is now id=3. I moved a bit the code to improve the ability to load templates and subscribers properly. I am planning to upstream `type` for templates API request so we can easily filter out and select the accordingly template.
Otherwise, Darwin will try to run them and fail.
|
Result of 1 package built:
|
matthiasbeyer
approved these changes
Aug 24, 2023
|
I kind of fucked up. I should have never included a patch like this, it will get broken soon when it will be merged ugh. |
|
Follow up in #251819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
It was impossible to package further versions before because listmonk upstream was using a very EOL Go version.
I was waiting for upstream to bump this, but it didn't happen, so I take the matters in my hand.
Hopefully, the upstream PR will be accepted.
Integration tests are fixed.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)