mprime-primenet: init at 30.19 #242600
Open
mprime-primenet: init at 30.19 #242600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
952690a to
b3455b6
Compare
|
Rebased and updated to use |
b3455b6 to
e65a16c
Compare
|
Updated package to latest version |
e65a16c to
0e4c59a
Compare
FliegendeWurst
requested changes
Nov 17, 2024
0e4c59a to
fd48b3b
Compare
Comment on lines
+78
to
+84
| description = "Mersenne prime search / System stability tester"; | ||
| longDescription = '' | ||
| MPrime is the Linux command-line interface version of Prime95, to be run | ||
| in a text terminal or in a terminal emulator window as a remote shell | ||
| client. It is identical to Prime95 in functionality, except it lacks a | ||
| graphical user interface. | ||
| ''; |
There was a problem hiding this comment.
At the moment these are identical to mprime. Both description and longDescription should indicate the purpose of this package variant
Comment on lines
+47
to
+52
| # src handled in non-standard way to allow for the hashes for fetchurl of the | ||
| # tarballs to match the checksums published on mersenne.org | ||
| src = tarball; | ||
| unpackPhase = '' | ||
| cp $src $(echo $src | cut --delimiter=- --fields=2-) | ||
| ''; |
There was a problem hiding this comment.
Why not tar xf $src in unpackPhase? And set dontBuild = true instead of overriding buildPhase?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This package adds official release builds for
mprime.mprimeis already packaged on nixpkgs but the existing package builds from source which prevents the binary from running workers connected to primenet, which is the easiest way to participate in GIMPS (Great Internet Mersenne Prime Search). I've tested running this with workers connected to primenet on both x86-linux and x86-macos with no issues so far.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)