Update socket2 in (some) packages for Rust 1.64 compatibility #194845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you need to run some one-off linux builds, you can ping me. Though OfBorg can do a lot, too. |
|
The beauty of new programming languages and distros. Gotta love it. not |
NilsIrl
reviewed
Oct 7, 2022
This fixes the build on Rust 1.64 since it contains an update of socket2 to a version greater than 0.3.16.
|
This is ready for review now. There are two remaining packages I can see are broken with this issue:
I'm not sure at this moment how much time I'll have to work on those, so I'd like to keep them separate from this. |
|
The MozWire part looks good to me 👍👍 |
|
All look OK and build for me on x86_64-linux, so let me merge relatively fast. Thanks for all the rust 1.64 fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates several packages on staging-next to use socket2 versions >= 0.3.16 so that they compile on Rust 1.64. The root cause is rust-lang/rust#78802. Related to #193494 (comment).
This leaves out several packages, either because I didn't get to them yet, I don't have a Linux machine ready for testing, or because I couldn't operate a part of the toolchain (e.g.
habitat,hydra-cli, etc.)For context, I am linking the PRs and issues opened upstream:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes