Skip to content

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Sep 28, 2022

Description of changes

Pulls in RonnyPfannschmidt/prance#132. I see that one of the commits changes the validator to use "auto-detection", and I don't know the implication of this, but the tests pass. Needed by #191339.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 28, 2022
@ofborg ofborg bot requested a review from costrouc September 28, 2022 02:51
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 28, 2022
@tjni
Copy link
Contributor Author

tjni commented Sep 28, 2022

There’s been very recent activity on the PR from which I am fetching. I will update this if that gets merged and released.

@jonringer
Copy link
Contributor

We could do the proper release bump on master; If this is building, I think we should just take it now.

@SuperSandro2000 SuperSandro2000 merged commit 20b8009 into NixOS:staging-next Sep 28, 2022
@tjni tjni deleted the prance branch September 28, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants