Skip to content

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Sep 15, 2022

@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: vim Advanced text editor 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 15, 2022
@vcunat
Copy link
Member Author

vcunat commented Sep 15, 2022

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Sep 15, 2022
@vcunat

This comment was marked as outdated.

Breaks tests for Celery.

This reverts commit e21f3ea.
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 29, 2022
@vcunat vcunat merged commit 8ba1204 into master Sep 29, 2022
@anthonyroussel anthonyroussel mentioned this pull request Sep 30, 2022
13 tasks
@vcunat
Copy link
Member Author

vcunat commented Oct 1, 2022

pkgsi686Linux.python3Packages.bcrypt segfaults during tests and consequently blocks many NixOS tests from running. I can reproduce that locally, but i686 tests don't seem very important.

@mweinelt
Copy link
Member

mweinelt commented Oct 1, 2022

pyca/bcrypt#407

jerith666 added a commit to jerith666/nixpkgs that referenced this pull request Nov 2, 2022
this was originally replaced with temurin in c742218, which landed
in staging in acf46b0 (NixOS#140364)

but it was also added in b6cb656 (in support of openjdk 18 in
da40a44), which landed directly on master in 9413ebb
(NixOS#165354).

those two conflicted when master was merged into staging-next in
a5dfac8 (NixOS#191339), and adoptopenjdk
17 was mistakenly kept during the conflict resolution.

the net result is that one would get:

$ nix-build -A pkgs.adoptopenjdk-hotspot-bin-17
error: Alias adoptopenjdk-hotspot-bin-17 is still in all-packages.nix

... instead of the desired:

$ nix-build -A pkgs.adoptopenjdk-hotspot-bin-17
error: AdoptOpenJDK is now Temurin. Use temurin-bin-17
@jerith666 jerith666 mentioned this pull request Nov 2, 2022
13 tasks
@ghost ghost mentioned this pull request Nov 7, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim Advanced text editor 8.has: clean-up This PR removes packages or removes other cruft 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.