Skip to content

Conversation

K900
Copy link
Contributor

@K900 K900 commented Sep 15, 2022

Description of changes

Lots of fixes for regressions in 0.3.57. https://gitlab.freedesktop.org/pipewire/pipewire/-/releases/0.3.58

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@K900 K900 requested review from jansol, jtojnar and mweinelt September 15, 2022 13:18
@ofborg ofborg bot requested a review from Kranzes September 15, 2022 13:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Sep 15, 2022
@K900 K900 merged commit 848bbe5 into NixOS:staging Sep 16, 2022
@jansol
Copy link
Contributor

jansol commented Sep 16, 2022

Whatever happened to the LC3 support you mentioned in the previous PR?

EDIT: ah, looking at the upstream commit log that seems to have narrowly missed the release.

@K900
Copy link
Contributor Author

K900 commented Sep 16, 2022

That's the next release.

@K900
Copy link
Contributor Author

K900 commented Sep 16, 2022

They decided to do another one before LC3 because .57 had a bunch of pretty nasty regressions.

@jansol
Copy link
Contributor

jansol commented Sep 16, 2022

Hmm I also had some weirdness with switching between bluetooth and wired headphones already in .56, which seems to be gone with .58 so that's nice too.

@vincentbernat vincentbernat mentioned this pull request Sep 24, 2022
13 tasks
@K900 K900 deleted the pipewire-0.3.58 branch July 27, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants