Skip to content

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jul 11, 2022

Without the change build with config.configurePlatformsByDefault = true
fails as:

$ nix build -f. fastjet-contrib --arg config '{ configurePlatformsByDefault = true; }' -L
configure flags: --prefix=/nix/store/mzfdbr6ygxw23w3fdnzbghjd819b5x72-fastjet-contrib-1.048 --build=x86_64-unknown-linux-gnu --host=x86_64-unknown-linux-gnu
Error: --build=x86_64-unknown-linux-gnu: unrecognised argument
Use fastjet-config --help for more information
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Without the change build with config.configurePlatformsByDefault = true
fails as:

    $ nix build -f. fastjet-contrib --arg config '{ configurePlatformsByDefault = true; }' -L
    configure flags: --prefix=/nix/store/mzfdbr6ygxw23w3fdnzbghjd819b5x72-fastjet-contrib-1.048 --build=x86_64-unknown-linux-gnu --host=x86_64-unknown-linux-gnu
    Error: --build=x86_64-unknown-linux-gnu: unrecognised argument
    Use fastjet-config --help for more information
@ofborg ofborg bot requested a review from veprbl July 11, 2022 08:00
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 11, 2022
@veprbl veprbl merged commit c78023c into NixOS:master Jul 11, 2022
@trofi trofi deleted the configurePlatforms-for-fastjet-contrib branch July 11, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants