Skip to content

librem-ec-acpi-dkms: init at 0.9.1 #134856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

librem-ec-acpi-dkms: init at 0.9.1 #134856

wants to merge 4 commits into from

Conversation

avieth
Copy link
Contributor

@avieth avieth commented Aug 19, 2021 •
edited
Loading

Motivation for this change

Users of NixOS on the Librem 14 laptop from Purism will want to include
this out-of-tree kernel module in their system configuration. Without it,
certain features are only partially usable (controls regarding power
source, LEDs, fans).

  boot.extraModulePackages = with config.boot.kernelPackages;
    [ librem-ec-acpi-dkms ];
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 19, 2021
SuperSandro2000
SuperSandro2000 reviewed Aug 19, 2021
View reviewed changes
@avieth avieth force-pushed the avieth/librem-ec-acmi-dkms branch 2 times, most recently from 7823b26 to ed67907 Compare August 20, 2021 20:45
@avieth
Copy link
Contributor Author

avieth commented Aug 20, 2021

I'll rebase and edit the commits to conform to the standard.

avieth added 2 commits August 20, 2021 17:18
@avieth
maintainers: add avieth
7bbb086
@avieth
librem-ec-acpi-dkms: init at 0.9.1
90e4f10 
Users of NixOS on the Librem 14 laptop from Purism will want to include
this out-of-tree kernel module in their system configuration

  boot.extraModulePackages = with config.boot.kernelPackages;
    [ librem-ec-acpi-dkms ];
@avieth avieth force-pushed the avieth/librem-ec-acmi-dkms branch from d5c8ad0 to 90e4f10 Compare August 20, 2021 21:18
@avieth avieth changed the title add librem-ec-acpi-dkms kernel module librem-ec-acpi-dkms: init at 0.9.1 Aug 20, 2021
SuperSandro2000
SuperSandro2000 reviewed Aug 20, 2021
View reviewed changes
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Aug 20, 2021
@avieth avieth force-pushed the avieth/librem-ec-acmi-dkms branch from 0d6bebf to 1b3159e Compare August 20, 2021 21:37
@sjamaan
Copy link
Contributor

sjamaan commented Sep 3, 2021

Can confirm, this package works for me (using librem14 v1)

@sjamaan
Copy link
Contributor

sjamaan commented Sep 3, 2021

NOTE: Without this, my battery wouldn't charge due to misconfigured default values that some devices seem to have (see this Purism forum thread)

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 12, 2021
@SuperSandro2000
Copy link
Member

@avieth please resolve the merge conflict.

@avieth
Copy link
Contributor Author

avieth commented Nov 12, 2021

@avieth please resolve the merge conflict.

Done

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 12, 2021
@ReplayCoding
Copy link
Contributor

Works on my librem 14

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 21, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 31, 2022
@K900
Copy link
Contributor

K900 commented Apr 5, 2023

Please resolve the merge conflicts, and rename the package to just librem-ec-acpi, as it's not actually built with DKMS (nor should it be).

@K900
Copy link
Contributor

K900 commented Apr 5, 2023

Also should probably be updated to the latest revision, as I can see fixes for newer kernels in there.

@wegank wegank marked this pull request as draft March 20, 2024 15:46
@Aleksanaa Aleksanaa closed this Oct 29, 2024
@sjamaan
Copy link
Contributor

sjamaan commented Oct 29, 2024

@Aleksanaa why did you close this? It looks like it wasn't merged.
I'm still using this and it would be great if this could be included in NixOS proper.

@Aleksanaa Aleksanaa reopened this Oct 29, 2024
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 29, 2024
@Aleksanaa
Copy link
Member

I'm sorting out things that haven't been active for quite a long time, without addressing requests.

@Aleksanaa
Copy link
Member

@sjamaan Could you copy this or #132706 and make a new PR for it, since you have the hardware?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 29, 2024
@sjamaan
Copy link
Contributor

sjamaan commented Oct 29, 2024

@sjamaan Could you copy this or #132706 and make a new PR for it, since you have the hardware?

Here you go: #352070

@sjamaan sjamaan mentioned this pull request Oct 29, 2024
Open
13 tasks
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@avieth @sjamaan @SuperSandro2000 @ReplayCoding @K900 @Aleksanaa @wegank