Skip to content

nodejs: fix hydra darwin builds #439129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

nodejs: fix hydra darwin builds #439129

merged 1 commit into from
Sep 1, 2025
+26 −3

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 1, 2025

Should fix https://hydra.nixos.org/build/306435782.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@aduh95 aduh95 mentioned this pull request Sep 1, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 1, 2025
@aduh95 aduh95 changed the title nodejs: fix hydra builds nodejs: fix hydra darwin builds Sep 1, 2025
@fabianhjr fabianhjr requested review from vcunat and emilazy September 1, 2025 14:34
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 1, 2025
emilazy
emilazy approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably patch these paths out entirely, but LGTM for now.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 1, 2025
@vcunat vcunat merged commit 4ce22ae into NixOS:staging-next Sep 1, 2025
37 of 39 checks passed
@aduh95 aduh95 deleted the fix-nodejs-hydra-build branch September 1, 2025 19:48
@vcunat
Copy link
Member

vcunat commented Sep 2, 2025

I'm afraid that it looks worse than it was:
https://hydra.nixos.org/build/306599808/nixlog/1/tail

This was referenced Sep 2, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduh95 @vcunat @emilazy