Skip to content

systemd-language-server: fix by relaxing lxlm dependency #438759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2025
Merged

systemd-language-server: fix by relaxing lxlm dependency #438759

merged 1 commit into from
Aug 31, 2025

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Aug 30, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage requested a review from kirillrdy August 30, 2025 23:53
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 30, 2025
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 438759

Logs: https://github.com/GaetanLepage/nixpkgs-review-gha/actions/runs/17349996983

x86_64-linux

✅ 2 packages built:
  • systemd-language-server
  • systemd-language-server.dist

aarch64-linux

✅ 2 packages built:
  • systemd-language-server
  • systemd-language-server.dist

x86_64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • systemd-language-server
  • systemd-language-server.dist
Error logs: `x86_64-darwin`
systemd-language-server 
            with self._condition:
                if self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]:
                    raise CancelledError()
                elif self._state == FINISHED:
                    return self.__get_result()

            self._condition.wait(timeout)

            if self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]:
                raise CancelledError()
            elif self._state == FINISHED:
                return self.__get_result()
            else:



>                   raise TimeoutError()

E                   TimeoutError


/nix/store/gkspnzkgarw4qvbl4670p3jcbgg6psrg-python3-3.13.6/lib/python3.13/concurrent/futures/_base.py:458: TimeoutError

=========================== short test summary info ============================

FAILED tests/test_server.py::test_hover[params0] - TimeoutError

========================= 1 failed, 9 passed in 9.64s ==========================

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • systemd-language-server
  • systemd-language-server.dist

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 438759
Commit: ab9b029b263cba2dd302c9bd34c83f0c67a08e82

x86_64-linux

✅ 2 packages built:
  • systemd-language-server
  • systemd-language-server.dist

aarch64-linux

✅ 2 packages built:
  • systemd-language-server
  • systemd-language-server.dist

x86_64-darwin

❌ 2 packages failed to build:
  • systemd-language-server
  • systemd-language-server.dist

aarch64-darwin

❌ 2 packages failed to build:
  • systemd-language-server
  • systemd-language-server.dist
Error logs: `x86_64-darwin`
systemd-language-server 
            with self._condition:
                if self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]:
                    raise CancelledError()
                elif self._state == FINISHED:
                    return self.__get_result()

            self._condition.wait(timeout)

            if self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]:
                raise CancelledError()
            elif self._state == FINISHED:
                return self.__get_result()
            else:





              raise TimeoutError()





E                   TimeoutError


/nix/store/gkspnzkgarw4qvbl4670p3jcbgg6psrg-python3-3.13.6/lib/python3.13/concurrent/futures/_base.py:458: TimeoutError

=========================== short test summary info ============================

FAILED tests/test_server.py::test_hover[params0] - TimeoutError

========================= 1 failed, 9 passed in 13.20s =========================

Error logs: `aarch64-darwin`
systemd-language-server 
            with self._condition:
                if self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]:
                    raise CancelledError()
                elif self._state == FINISHED:
                    return self.__get_result()

            self._condition.wait(timeout)

            if self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]:
                raise CancelledError()
            elif self._state == FINISHED:
                return self.__get_result()
            else:





              raise TimeoutError()





E                   TimeoutError


/nix/store/9px7zzsfnlmj61yy2fpl6z14w93j05is-python3-3.13.6/lib/python3.13/concurrent/futures/_base.py:458: TimeoutError

=========================== short test summary info ============================

FAILED tests/test_server.py::test_hover[params0] - TimeoutError

========================= 1 failed, 9 passed in 4.59s ==========================

@GaetanLepage GaetanLepage force-pushed the systemd-language-server branch from ab9b029 to 8488f9a Compare August 31, 2025 00:01
@GaetanLepage GaetanLepage requested a review from kirillrdy August 31, 2025 00:05
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 31, 2025
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 438759

Logs: https://github.com/GaetanLepage/nixpkgs-review-gha/actions/runs/17350053975

x86_64-linux

✅ 2 packages built:
  • systemd-language-server
  • systemd-language-server.dist

aarch64-linux

✅ 2 packages built:
  • systemd-language-server
  • systemd-language-server.dist

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • systemd-language-server
  • systemd-language-server.dist

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • systemd-language-server
  • systemd-language-server.dist

@GaetanLepage GaetanLepage merged commit b536f7a into NixOS:master Aug 31, 2025
32 of 36 checks passed
@GaetanLepage GaetanLepage deleted the systemd-language-server branch August 31, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillrdy kirillrdy Awaiting requested review from kirillrdy

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaetanLepage @kirillrdy