vimPlugins: remove buildVimPlugin from overrides.nix
#438708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
My mind immediately jumps to "how can we enforce that via CI"; cc @NixOS/nixpkgs-ci Although, I'm wary of a solution that costs too much dev time being designed and implemented, for too little devex gain when it's done. It may also be possible to check that |
eedb955 to
4251c2e
Compare
|
sorry, formatter must have gone haywire on taskwarrior commits. |
pkgs/applications/editors/vim/plugins/non-generated/fzf-wrapper/default.nix
Outdated
Show resolved
Hide resolved
MattSturgeon
approved these changes
Aug 30, 2025
Looks like it was missed in `overrides.nix` when it should be in non-generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Looks like it was missed in `overrides.nix` when it should be in non-generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Looks like it was missed in `overrides.nix` when it should be in non-generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Looks like it was missed in `overrides.nix` when it should be in non-generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Upstream repository removed. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Looks like it was missed in `overrides.nix` when it should be in non-generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Looks like it was missed in `overrides.nix` when it should be in non-generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Looks like it was missed in `overrides.nix` when it should be in non-generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Looks like it was missed in `overrides.nix` when it should be in non-generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Looks like it was missed in `overrides.nix` when it should be in non-generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Looks like it was missed in `overrides.nix` when it should be in non-generated. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
We want to prevent plugins being added in `overrides.nix`. Shadow the helper names to throw if someone tries to add them and use them in the file. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
We want
overrides.nixto be strictly overrides and not new plugin definitions.passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.