Skip to content

python3Packages.torch: backport a triton 2.4 support patch #436960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

python3Packages.torch: backport a triton 2.4 support patch #436960

wants to merge 1 commit into from
+87 −0

Conversation

LunNova
Copy link
Member

@LunNova LunNova commented Aug 26, 2025 •
edited
Loading

Fixes an error which occurs after triton was bumped from 2.3.1 to 2.4 in 1a3d391

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@LunNova LunNova requested a review from GaetanLepage August 26, 2025 00:52
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 26, 2025
@LunNova LunNova mentioned this pull request Aug 26, 2025
Merged
13 tasks
@LunNova
python3Packages.torch: backport a triton 2.4 support patch
2db0234 
Fixes an error which occurs after triton was bumped from 2.3.1 to 2.4
in 1a3d391
@LunNova LunNova force-pushed the lunnova/triton-2.4-compat branch from dbf927a to 2db0234 Compare August 26, 2025 01:00
@LunNova
Copy link
Member Author

LunNova commented Aug 26, 2025

torchWithRocm is failing so leaving as draft, will rebase after #436500 goes in and I can test properly.

@LunNova
Copy link
Member Author

LunNova commented Aug 27, 2025

This is unneeded as torch will get bumped to 2.8 soon.

@LunNova LunNova closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage Awaiting requested review from GaetanLepage

Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LunNova