Skip to content

calamares-nixos-extensions: shrink assets #434243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2025
Merged

calamares-nixos-extensions: shrink assets #434243

merged 1 commit into from
Aug 16, 2025

Conversation

K900
Copy link
Contributor

@K900 K900 commented Aug 16, 2025

Remove Lumina because it compresses awfully and is currently unused. All other images: magick mogrify -resize 1920x1080 -format jpg -quality 80 *.png

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@K900
calamares-nixos-extensions: shrink assets
c1cff81 
Remove Lumina because it compresses awfully and is currently unused.
All other images: magick mogrify -resize 1920x1080 -format jpg -quality 80 *.png
@K900 K900 mentioned this pull request Aug 16, 2025
Merged
20 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 16, 2025
@eclairevoyant
Copy link
Contributor

Is AVIF or HEIC supported? Presumably we could shrink further with those.

@K900
Copy link
Contributor Author

K900 commented Aug 16, 2025

Theoretically yes, with qtimageformats, but the returns are significantly diminished.

philiptaron
philiptaron approved these changes Aug 16, 2025
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; will do a build.

pkgs/by-name/ca/calamares-nixos-extensions/src/branding/nixos/images/deepin.jpg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one goes away in #430298 right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 434243
Commit: c1cff8190f39270290a7824534a8e7ae5c1666f1

x86_64-linux

✅ 2 packages built:
  • calamares-nixos
  • calamares-nixos-extensions

@philiptaron
Copy link
Contributor

philiptaron commented Aug 16, 2025 •
edited
Loading 

$ gh api /repos/nixos/nixpkgs/tarball/c1cff8190f39270290a7824534a8e7ae5c1666f1 | wc -c | numfmt --to=iec --suffix=B
45MB

Still about 2MiB chunkier than release-25.05 but we have lots of levers to impact that. Thanks for the quick and effective PR @K900.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 16, 2025
@philiptaron philiptaron merged commit a05a770 into NixOS:master Aug 16, 2025
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron philiptaron approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@K900 @eclairevoyant @philiptaron