Skip to content

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Aug 15, 2025

Things done

Closes #429237

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 15, 2025
@nix-owners nix-owners bot requested a review from LordGrimmauld August 15, 2025 23:58
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 15, 2025
@LordGrimmauld
Copy link
Contributor

I just checked 1.0.2: https://github.com/FreeCAD/FreeCAD/blob/1.0.2/src/Gui/Application.cpp#L2260-L2275
Turns out that patch is not (yet) picked to that release branch. So while #431206 will conflict with this PR in git, this indeed looks like the correct (long-ish) term fix. Thank you for looking into this! I'll do one last build and test, but looking good.

Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, i can reproduce the crash and i can confirm this patch fixes it. Thank you for looking into this.

@LordGrimmauld LordGrimmauld merged commit bb51f7e into NixOS:master Aug 16, 2025
31 of 34 checks passed
@NickCao NickCao deleted the freecad-wayland-fix branch August 16, 2025 20:31
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/which-package-for-freecad/67961/9

@LordGrimmauld LordGrimmauld added the backport release-25.05 Backport PR automatically label Aug 16, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 16, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-434105-to-release-25.05 origin/release-25.05
cd .worktree/backport-434105-to-release-25.05
git switch --create backport-434105-to-release-25.05
git cherry-pick -x 3d0c9bbafc65260634b71a50bf8897d2ceab0090

@LordGrimmauld
Copy link
Contributor

25.05 doesn't have coin 4.0.4+ yet. If it does update, we'll need to backport this fix. If it had applied cleanly, i'd have just done it - it doesn't hurt on older coin3d. However, seeing as it would need a manual backport, i'll not bother for now until the coin backport is drafted.

@mdaniels5757
Copy link
Contributor

@mdaniels5757 mdaniels5757 added 8.has: port to stable This PR already has a backport to the stable release. and removed backport release-25.05 Backport PR automatically labels Aug 16, 2025
@Lite5h4dow
Copy link
Contributor

Lite5h4dow commented Aug 24, 2025

@LordGrimmauld
Im still having rendering issues with this branch

2025-08-24.21-27-54.mp4
2025-08-24.21-26-39.mp4

@LordGrimmauld
Copy link
Contributor

couple notes:

  • the video doesn't play for me
  • this was never meant to fix rendering issues. The issue fixed here was a hard crash.
  • Rendering issues are a new bug. Open a dedicated issue report for that and i can maybe take a look. Be aware though rendering issues can be hardware/driver dependent, it is often not trivial to reproduce those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

freecad: segfault when opening file
5 participants