Skip to content

comet-gog_heroic: init at 0.2.0; comet-gog: refactor, add dummy-service passthru #434055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

comet-gog_heroic: init at 0.2.0; comet-gog: refactor, add dummy-service passthru #434055

wants to merge 3 commits into from

Conversation

TomaSajt
Copy link
Contributor

Complementary PR for #432183

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt mentioned this pull request Aug 15, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 15, 2025
@aidalgol
Copy link
Contributor

Isn't all-packages.nix deprecated, and packages shouldn't be added there anymore?

@TomaSajt
Copy link
Contributor Author

There are some things that can't/shouldn't be migrated.

E.g. lots of packages have overrides, and have variants like helloFull, which is just the original package but with all optional flags toggled on.
And these variants can't really be migrated to by-name (I won't explain why, but I can if you want to)

@aidalgol
Copy link
Contributor

Do you mind if I roll this into #432183 (via cherry-picking)?

@TomaSajt
Copy link
Contributor Author

Sure
I am away for the next 4 days, so I won't be able to make changes to my PR anyways.

@TomaSajt
Copy link
Contributor Author

Closing in favor of #432183, which has already cherry-picked the changes in this PR.

@TomaSajt TomaSajt closed this Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomaSajt @aidalgol