Skip to content

Conversation

sh4k095
Copy link

@sh4k095 sh4k095 commented Aug 12, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium August 12, 2025 20:00
@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Aug 12, 2025
hash = "sha256-mVN+9PTwEMD24KV3Eyp0Jq4vgA1Zs+jThdEbVcfs6pw=";
};

dependencies = with pkgs.python312Packages; [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dependencies = with pkgs.python312Packages; [
dependencies = [

fetchFromGitHub,
buildPythonPackage,
pythonOlder,
setuptools,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in pkgs/development/python-modules you need to import each dependency at a package:

Suggested change
setuptools,
setuptools,
meson,
meson-python,
ninja,
cython,
numpy,
scipy,
ase,
packaging,

@sh4k095
Copy link
Author

sh4k095 commented Aug 15, 2025

@Sigmanificient, I added the dependencies as requested. I am trying to build the package, but I face failure due to a script (discorver_version.py, in the original repository, here) being unable to parse the package version. The script is trying to parse the package version either from git or from the first line of a file 'PKG-INFO' and fails. Is there a way to get around this? Perhaps creating a PKG-INFO containing the version string upon building?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants