Skip to content

python313: revert commit that locks ssl sockets #432368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 10, 2025
Merged

python313: revert commit that locks ssl sockets #432368

merged 3 commits into from
Aug 10, 2025

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Aug 9, 2025 •
edited
Loading

This breaks among other things the websockets package and is due to be
reverted in 3.13.7.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@mweinelt
python313: revert commit that locks ssl sockets
5f974fa 
This breaks among other things the websockets package and is due to be
reverted in 3.13.7.
@mweinelt
Revert "python313Packages.websockets: temporarily disable tests"
9f8df5b 
This reverts commit 74f87a6.

The problematic commmit in Python 3.13.6 has been reverted, so we can now
reenable the test suite.
@nix-owners nix-owners bot requested a review from natsukium August 9, 2025 22:09
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 9, 2025
@nix-owners nix-owners bot requested a review from fabaff August 9, 2025 22:17
@mweinelt mweinelt merged commit 3e0f510 into NixOS:staging Aug 10, 2025
25 of 28 checks passed
@mweinelt mweinelt deleted the python-3.13.6-revert-ssl-lock branch August 10, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium Awaiting requested review from natsukium

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mweinelt