Skip to content

qogir-cursors-recolored: init at 0-unstable-2023-10-03 #432364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

qogir-cursors-recolored: init at 0-unstable-2023-10-03 #432364

wants to merge 2 commits into from
+148 −0

Conversation

mushrowan
Copy link

Description of changes

qogir-cursors-recolored: init at 2023-10-03
https://github.com/TeddyBearKilla/Qogir-Cursors-Recolored
I basically copied #284617 with a couple of tweaks related to capitalisation to make it work.

My first PR so please let me know if I've messed up :)

Basically a copy of the PR I made before @ #432246. I managed to mess something up so badly that it autoclosed my PR and wouldn't let me open. Hopefully won't break it again :(

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@mushrowan mushrowan mentioned this pull request Aug 9, 2025
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 12.first-time contribution This PR is the author's first one; please be gentle! 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 9, 2025
@mushrowan
Copy link
Author

Main thing which wasn't resolved from previous PR:
#432246 (comment)

@yzhou216
Copy link
Contributor

The PR title and commit message should be qogir-cursors-recolored: init at 0-unstable-2023-10-03 if that's the version you are using in the derivation.

@mushrowan mushrowan changed the title qogir-cursors-recolored: init at 2023-10-03 qogir-cursors-recolored: init at 0-unstable-2023-10-03 Aug 12, 2025
@mushrowan
Copy link
Author

The PR title and commit message should be qogir-cursors-recolored: init at 0-unstable-2023-10-03 if that's the version you are using in the derivation.

thanks! fixed :)

yzhou216

This comment was marked as duplicate.

Sign in to view

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 12, 2025
@mushrowan mushrowan closed this Aug 13, 2025
@mushrowan mushrowan deleted the qogir-recolored branch August 13, 2025 19:09
@mushrowan mushrowan restored the qogir-recolored branch August 13, 2025 19:10
@mushrowan mushrowan reopened this Aug 13, 2025
@mushrowan
Copy link
Author

didn't mean to delete, oops

yzhou216
yzhou216 suggested changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@yzhou216 yzhou216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit that adds yourself as a maintainer should be the first commit. Would you mind rebasing it?

@mushrowan
Copy link
Author

The commit that adds yourself as a maintainer should be the first commit. Would you mind rebasing it?

done :)

@yzhou216
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432364

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/16960965969

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-432364-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/42i7s5dgaqx0nmmsb2y5r3dvhmbwzrfk-qogir-cursors-recolored-0-unstable-2023-10-03
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-432364-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/r1yj8d7a0a7fb4bwjh4vaxiahj65gzsi-qogir-cursors-recolored-0-unstable-2023-10-03
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-432364-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/rlx2d7gn2b8kj3lp9wr1jfgynw3bhilz-qogir-cursors-recolored-0-unstable-2023-10-03
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-432364-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/i366fzwjdx722glm763iqs0fmz909y7d-qogir-cursors-recolored-0-unstable-2023-10-03

x86_64-linux

✅ 1 package built:
  • qogir-cursors-recolored

aarch64-linux

✅ 1 package built:
  • qogir-cursors-recolored

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • qogir-cursors-recolored

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • qogir-cursors-recolored

yzhou216
yzhou216 approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@yzhou216 yzhou216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@mushrowan
Copy link
Author

bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@yzhou216 yzhou216 yzhou216 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mushrowan @yzhou216