-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
asahi-plymouth-theme: init at 0.2 #432344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup
226fcde
to
1c0a031
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved automatically following the successful run of nixpkgs-review
.
Were you able to run/test this theme on your machine, either by adding it to your nixos module configuration or other means? |
I haven't tried. Not familiar with Plymouth theme. |
That's okay, just wanted full context for your approval which seems to just be for derivation code quality. Thank you for reviewing. |
I'm no longer interested in maintaining this package nor seeing it merged into nixpkgs. I will keep the branch open for posterity. |
hompage: https://github.com/AsahiLinux/asahi-plymouth
Fun little plymouth boot splash meant to mimic Apple's bootsplash but for Asahi machines.
Module configuration for testing:
Known limitation of not being present during the LUKS password prompt screen. Also, the bar doesn't fill up all the way possibly due to how fast NixOS boots.
I had this patch sitting for a while, but didn't find the motivation to submit it due to the dodgy license of one of the images which was fixed in AsahiLinux/asahi-plymouth@14f4f70 for the 0.2 release.
Things done
passthru.tests
.nixpkgs-review
on this PR. See nixpkgs-review usage../result/bin/
.Add a 👍 reaction to pull requests you find important.
asahi-plymouth-theme: init at 0.2
asahi-plymouth-theme: init at 0.2