Skip to content

cook-cli: 0.12.1 -> 0.14.0 #432322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

cook-cli: 0.12.1 -> 0.14.0 #432322

merged 1 commit into from
Aug 19, 2025

Conversation

awwithro
Copy link
Contributor

@awwithro awwithro commented Aug 9, 2025 •
edited
Loading

Updating cook-cli to the latest release:
https://github.com/cooklang/cookcli/releases/tag/v0.14.0

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Aug 9, 2025
@nix-owners nix-owners bot requested a review from emilioziniades August 9, 2025 18:40
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 9, 2025
Erethon
Erethon approved these changes Aug 9, 2025
View reviewed changes
Copy link
Contributor

@Erethon Erethon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, build on NixOS x86-64 and works fine.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432322
Commit: 844718737e14a68621b04fd45c91574abe0e7d72

x86_64-linux

✅ 1 package built:
  • cook-cli

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 9, 2025
@emilioziniades
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432322
Commit: 844718737e14a68621b04fd45c91574abe0e7d72

x86_64-darwin

✅ 1 package built:
  • cook-cli

emilioziniades
emilioziniades approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@emilioziniades emilioziniades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Built locally and tested

@awwithro
Copy link
Contributor Author

How long are the passthru tests typically queued for?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 12, 2025
@Sigmanificient Sigmanificient merged commit 458f055 into NixOS:master Aug 19, 2025
38 of 39 checks passed
@Sigmanificient
Copy link
Member

@awwithro aarch64 always take a lot of time unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Erethon Erethon Erethon approved these changes

@emilioziniades emilioziniades emilioziniades approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awwithro @emilioziniades @Sigmanificient @Erethon