Skip to content

python3Packages.sanic: re-enable darwin tests #432262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

python3Packages.sanic: re-enable darwin tests #432262

merged 1 commit into from
Aug 22, 2025

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Aug 9, 2025

Tests seem to be working now. A single test failed because of the usual socket length issue, but I added the usual workaround.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Aug 9, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 9, 2025
@nix-owners nix-owners bot requested a review from p0lyw0lf August 9, 2025 13:33
@ofalvai ofalvai marked this pull request as draft August 9, 2025 13:57
@ofalvai ofalvai force-pushed the push-lyzmzwwxnrkp branch from 568034c to 8e20402 Compare August 9, 2025 17:32
@ofalvai ofalvai marked this pull request as ready for review August 9, 2025 17:34
p0lyw0lf
p0lyw0lf approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@p0lyw0lf p0lyw0lf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass on my x86_64-darwin & aarch64-darwin too, LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 13, 2025
@Sigmanificient Sigmanificient merged commit aa3c849 into NixOS:master Aug 22, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@p0lyw0lf p0lyw0lf p0lyw0lf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofalvai @p0lyw0lf @Sigmanificient