Skip to content

python3Packages.openeo: init at 0.43.0 #432186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

python3Packages.openeo: init at 0.43.0 #432186

wants to merge 4 commits into from

Conversation

ElrohirGT
Copy link
Contributor

Adds openeo 0.43.0 to python packages. I've only tested this package with 3.12. It doesn't support 3.13 yet.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium August 9, 2025 05:54
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 9, 2025
acid-bong
acid-bong suggested changes Aug 9, 2025
View reviewed changes
acid-bong
acid-bong reviewed Aug 9, 2025
View reviewed changes
@acid-bong
Copy link
Contributor

It doesn't support 3.13 yet.

add disabled = pythonAtLeast "3.13";

@ElrohirGT
Copy link
Contributor Author

Sorry for not adressing this earlier. I'll try to get back to it as ASAP.

@ElrohirGT
Copy link
Contributor Author

add disabled = pythonAtLeast "3.13";

This package should only be available to 3.12 python, maybe 3.10 but some dependencies would need to change most likely. How can I define it to only be available for 3.12?

If i'm not mistaken your suggestion would make it available for 3.13 and higher which is not correct.

@ElrohirGT
Copy link
Contributor Author

All other suggestions were addressed!

@acid-bong
Copy link
Contributor

your suggestion would make it available for 3.13 and higher

nope, the attr is literally called "disabled", so the package will be disabled for python313+, throwing a PACKAGE is unavailable for Python PYTHONVERSION error on them

acid-bong
acid-bong reviewed Aug 10, 2025
View reviewed changes
@acid-bong
Copy link
Contributor

and just realised: the correct title should be python3Packages.openeo: init at 0.43.0

@ElrohirGT
Copy link
Contributor Author

your suggestion would make it available for 3.13 and higher

nope, the attr is literally called "disabled", so the package will be disabled for python313+, throwing a PACKAGE is unavailable for Python PYTHONVERSION error on them

Gotcha! Done!

@ElrohirGT ElrohirGT changed the title openeo: init at version 0.43.0 python3Packages.openeo: init at version 0.43.0 Aug 10, 2025
@ElrohirGT
Copy link
Contributor Author

and just realised: the correct title should be python3Packages.openeo: init at 0.43.0

Done!

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 10, 2025
@acid-bong
Copy link
Contributor

On the other hand, why should we disable the package on Python 3.13? Yes, it's not listed in classifiers, but it's not restricted in python_requires either: https://github.com/Open-EO/openeo-python-client/blob/v0.43.0/setup.py#L68

@ElrohirGT
Copy link
Contributor Author

On the other hand, why should we disable the package on Python 3.13? Yes, it's not listed in classifiers, but it's not restricted in python_requires either: https://github.com/Open-EO/openeo-python-client/blob/v0.43.0/setup.py#L68

My reasoning was that since in the project README they only list until 3.12, I didn't even bother to try building it for 3.13.

Screenshot_2025-08-10-00-05-52-760_com.github.android-edit.jpg

Have a good night! I'll see the PR tomorrow.

dotlambda
dotlambda reviewed Aug 11, 2025
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions.

@ElrohirGT ElrohirGT changed the title python3Packages.openeo: init at version 0.43.0 python312Packages.openeo: init at version 0.43.0 Aug 12, 2025
@ElrohirGT
Copy link
Contributor Author

Please follow https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions.

I thought having python3Packages.openeo was following it.

Renamed the commit and PR title to 312 to be more specific.

@dotlambda
Copy link
Member

Please follow https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions.

I thought having python3Packages.openeo was following it.

It's about the "version" in the commit message.

@dotlambda dotlambda changed the title python312Packages.openeo: init at version 0.43.0 python3Packages.openeo: init at 0.43.0 Aug 12, 2025
dotlambda
dotlambda reviewed Aug 12, 2025
View reviewed changes
pkgs/development/python-modules/openeo/default.nix
hash = "sha256-zeUASaj1XbcH8NE2+AalH8Jc0tocwotKwJ5QAtrf0kE=";
};

pythonRelaxDeps = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a list of packages if possible.

pkgs/development/python-modules/openeo/default.nix Outdated
pname = "openeo";
version = "0.43.0";
pyproject = true;
disabled = pythonAtLeast "3.13";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
disabled = pythonAtLeast "3.13";

I doubt that's needed.

pkgs/development/python-modules/openeo/default.nix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add nativeCheckInputs (pytestCheckInputs etc) and pythonImportsCheck.

ElrohirGT and others added 3 commits August 13, 2025 19:01
@nixpkgs-ci nixpkgs-ci bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@natsukium natsukium Awaiting requested review from natsukium

+1 more reviewer

@acid-bong acid-bong acid-bong requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElrohirGT @acid-bong @dotlambda