Heroic: fix helper programs #432183

aidalgol · 2025-08-09T05:41:26Z

Package missing Windows helper executables for Heroic Games Launcher.
Pin versions of helper programs where there is a newer version upstream.

Things done

Add a 👍 reaction to pull requests you find important.

keenanweaver

Looks good! Did not test actual functionality. Not sure how to actually test these features without downloading GTA5. Added some suggestions.

`nixpkgs-review` result for #432183

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432183

Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/16851392980

`x86_64-linux`

✅ 4 packages built:

galaxy-dummy-service
heroic
heroic-epic-integration
heroic-unwrapped

`aarch64-linux`

✅ 2 packages built:

galaxy-dummy-service
heroic-epic-integration

`x86_64-darwin` (sandbox = true)

✅ 2 packages built:

galaxy-dummy-service
heroic-epic-integration

`aarch64-darwin` (sandbox = true)

✅ 2 packages built:

galaxy-dummy-service
heroic-epic-integration

pkgs/by-name/he/heroic-epic-integration/package.nix

pkgs/by-name/ga/galaxy-dummy-service/package.nix

keenanweaver

`nixpkgs-review` result for #432183

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432183

Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/16854007428

`x86_64-linux`

✅ 4 packages built:

galaxy-dummy-service
heroic
heroic-epic-integration
heroic-unwrapped

`aarch64-linux`

✅ 2 packages built:

galaxy-dummy-service
heroic-epic-integration

`x86_64-darwin` (sandbox = true)

✅ 2 packages built:

galaxy-dummy-service
heroic-epic-integration

`aarch64-darwin` (sandbox = true)

✅ 2 packages built:

galaxy-dummy-service
heroic-epic-integration

pkgs/by-name/he/heroic-unwrapped/package.nix

keenanweaver

Everything functioning correctly as far as I can tell.

What's the maintenance you have in mind for all these different package versions? I can see things getting out of hand quickly with all the updates done to these components.

A bit out of my wheelhouse on this. Trying to understand if this is the best approach for the Heroic package. It just feels like there might be an easier way to do this. I looked around nixpkgs to see other examples of 'latest' vs. 'versioned' components. There are packages like podofo and uhttpmock which have distinct packages per version. In openrct2, the dependencies are built into the same derivation (though those are just fetchurl). Would it be desirable to do that for Heroic? Probably need someone more experienced than me to chime in on this.

`nixpkgs-review` result for #432183

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432183

Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/16907509795

`x86_64-linux`

✅ 6 packages built:

comet-gog
comet-gog_0_2_0
galaxy-dummy-service_0_2_0
heroic
heroic-epic-integration_0_3
heroic-unwrapped

`aarch64-linux`

✅ 4 packages built:

comet-gog
comet-gog_0_2_0
galaxy-dummy-service_0_2_0
heroic-epic-integration_0_3

`x86_64-darwin` (sandbox = true)

✅ 4 packages built:

comet-gog
comet-gog_0_2_0
galaxy-dummy-service_0_2_0
heroic-epic-integration_0_3

`aarch64-darwin` (sandbox = true)

✅ 4 packages built:

comet-gog
comet-gog_0_2_0
galaxy-dummy-service_0_2_0
heroic-epic-integration_0_3

CommandMC · 2025-08-12T12:20:43Z

This is likely not how you (intend to) do things in Nix land, but it'd be possible to just keep the binaries Heroic ships instead of building them yourself. FWIW this is how basically every other Linux package of Heroic works

keenanweaver · 2025-08-12T13:32:52Z

This is likely not how you (intend to) do things in Nix land, but it'd be possible to just keep the binaries Heroic ships instead of building them yourself. FWIW this is how basically every other Linux package of Heroic works

Ideally in Nix you want to build everything from source. For these Heroic components, though, I can see it being better to just put in the pre-compiled binaries, as I don't think these components are used in other software at this point in time. We can also have our cake and eat it too by having separate derivations for them (for the 'latest' versions only), and in the heroic package, just have the binaries downloaded. This is just my opinion and hope to see others' opinions.

aidalgol · 2025-08-12T22:32:47Z

Everything functioning correctly as far as I can tell.

What's the maintenance you have in mind for all these different package versions? I can see things getting out of hand quickly with all the updates done to these components.

My plan is to manually bump them when Heroic releases come out, and see how that goes.

A bit out of my wheelhouse on this. Trying to understand if this is the best approach for the Heroic package. It just feels like there might be an easier way to do this. I looked around nixpkgs to see other examples of 'latest' vs. 'versioned' components. There are packages like podofo and uhttpmock which have distinct packages per version. In openrct2, the dependencies are built into the same derivation (though those are just fetchurl).

I think embedded derivations is generally discouraged. It would also make it difficult (or at least awkward) to override any of the package versions, and these packages can potentially be used outside of Heroic.

pkgs/by-name/co/comet-gog/package.nix

TomaSajt · 2025-08-13T11:54:18Z

pkgs/by-name/co/comet-gog_0_2_0/package.nix

+}:
+
+rustPlatform.buildRustPackage (finalAttrs: {
+  inherit (comet-gog) pname;


I think you should just set the pname to "comet-gog"

I'd rather keep this inherit, since we still want to reuse comet-gog.meta further down the file.

pkgs/by-name/ga/galaxy-dummy-service_0_2_0/package.nix

TomaSajt · 2025-08-15T19:56:14Z

Here it is: #434055

TomaSajt · 2025-08-15T20:02:44Z

heroic-epic-intergration, IMO should be just defined next to package.nix and then callPackage-ed directly from heroic's package.nix.

For gogdl maybe something similar could be done to what I did with comet-gog in my PR.
Though it'll be a bit weird that the pinned version is the same as the latest version.

SuperSandro2000 · 2025-08-16T15:34:53Z

pkgs/by-name/he/heroic-epic-integration/package.nix

+    maintainers = with lib.maintainers; [ aidalgol ];
+  };
+
+  passthru.updateScript = gitUpdater { };


meta should always be written after passhru.

SuperSandro2000 · 2025-08-16T15:35:24Z

pkgs/by-name/ga/galaxy-dummy-service/package.nix

+    runHook preInstall
+
+    mkdir $out
+    cp GalaxyCommunication.exe $out/


Shouldn't this be under $out/bin?

I wasn't sure, since it's a Windows executable.

SuperSandro2000 · 2025-08-16T15:42:13Z

pkgs/by-name/he/heroic-epic-integration/package.nix

+    runHook preInstall
+
+    mkdir $out
+    cp heroic-epic-integration.exe $out/EpicGamesLauncher.exe


We need to keep the helper programs at the same versions as upstream, so updating just this package is insufficient.

- comet-gog.dummy-service - epic-integration

aidalgol · 2025-08-17T03:39:36Z

Cherry-picked all commits from #434055 and rebased this PR.

This is a fork only for Heroic, so move the nix file for this derivation to beside heroic-unwrapped, but expose it as a passthru for ease of overriding.

keenanweaver · 2025-08-17T19:59:18Z

Getting an error in the logs, but the multiplayer component is still working. (As in, I can see servers and join)

(14:47:48) [INFO]:    [Backend]:         Launching Heretic + Hexen (1776058590)
(14:47:48) [INFO]:    [Backend]:         Checking if wine version exists: Proton - proton-ge-bin
(14:47:48) [INFO]:    [Backend]:         Checking if wine version exists: Proton - proton-ge-bin
(14:47:48) [INFO]:    [Backend]:         Checking if wine version exists: Proton - proton-ge-bin
(14:47:48) [INFO]:    [Backend]:         Checking if wine version exists: Proton - proton-ge-bin
(14:47:48) [DEBUG]:   [Backend]:         Running Wine command: createprefix
(14:47:48) [INFO]:    [Backend]:         Preventing machine to sleep
(14:47:50) [INFO]:    [Backend]:         Checking if wine version exists: Proton - proton-ge-bin
(14:47:50) [DEBUG]:   [Backend]:         Running Wine command: cmd /c winepath -u C:\ProgramData\GOG.com\Galaxy\redists\GalaxyCommunication.exe
(14:47:52) [ERROR]:   Failed to install GalaxyCommunication dummy into the prefix: Error: ENOENT, build/bin/x64/win32/GalaxyCommunication.exe not found in /nix/store/g87rxkfkfs11r0w7wmsrcdz9hbw1f6nw-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar
    at createError (node:electron/js2c/node_init:2:2060)
    at Object.copyFile (node:electron/js2c/node_init:2:4140)
    at Ts (/nix/store/g87rxkfkfs11r0w7wmsrcdz9hbw1f6nw-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar/build/main/main.js:142:932)
    at Module.Qc [as launch] (/nix/store/g87rxkfkfs11r0w7wmsrcdz9hbw1f6nw-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar/build/main/main.js:16:5680)
    at No (/nix/store/g87rxkfkfs11r0w7wmsrcdz9hbw1f6nw-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar/build/main/main.js:128:1469)
    at Session.<anonymous> (node:electron/js2c/browser_init:2:106823)
(14:47:53) [INFO]:    [Gog]:             Launching Comet!
(14:47:53) [INFO]:    [Gog]:             Launching Heretic + Hexen: HEROIC_APP_NAME=1776058590 HEROIC_APP_RUNNER=gog GAMEID=umu-0 HEROIC_APP_SOURCE=gog STORE=gog STEAM_COMPAT_INSTALL_PATH="/home/keenan/Games/Heroic/Heretic + Hexen" PULSE_SINK=Game LD_PRELOAD= STEAM_COMPAT_CLIENT_INSTALL_PATH=/home/keenan/.local/share/.steam/steam WINEPREFIX="/home/keenan/Games/Heroic/Prefixes/default/Heretic  Hexen" STEAM_COMPAT_DATA_PATH="/home/keenan/Games/Heroic/Prefixes/default/Heretic  Hexen" PROTONPATH=/home/keenan/.config/heroic/tools/proton/proton-ge-bin WINE_FULLSCREEN_FSR=0 PROTON_ENABLE_WAYLAND=1 PROTON_ENABLE_HDR=1 PROTON_USE_WOW64=1 PROTON_DISABLE_NVAPI=1 PROTON_EAC_RUNTIME=/home/keenan/.config/heroic/tools/runtimes/eac_runtime PROTON_BATTLEYE_RUNTIME=/home/keenan/.config/heroic/tools/runtimes/battleye_runtime STEAM_COMPAT_APP_ID=0 SteamAppId=0 SteamGameId="heroic-Heretic + Hexen" PROTON_LOG_DIR=/home/keenan/.local/share GOGDL_CONFIG_PATH=/home/keenan/.config/heroic/gogdlConfig /nix/store/g87rxkfkfs11r0w7wmsrcdz9hbw1f6nw-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/keenan/.config/heroic/gog_store/auth.json launch "/home/keenan/Games/Heroic/Heretic + Hexen" 1776058590 --no-wine --wrapper "obs-gamecapture /etc/profiles/per-user/keenan/bin/mangohud --dlsym "/usr/bin/umu-run"" --platform windows
(14:47:53) [DEBUG]:   [Gog]:             Logging to file(s) "/home/keenan/.local/state/Heroic/logs/games/1776058590_gog/launch.log", "/home/keenan/.local/state/Heroic/logs/runners/gog.log"
(14:47:53) [INFO]:    [Backend]:         Preventing display to sleep
(14:48:37) [INFO]:    [Gog]:             Killing Comet!

When installing a new game. Again, multiplayer is seemingly working as intended.

(14:54:24) [DEBUG]:   [Backend]:         Running Wine command: cmd /c winepath -u C:\ProgramData\GOG.com\Galaxy\redists\GalaxyCommunication.exe
(14:54:26) [ERROR]:   Failed to install GalaxyCommunication dummy into the prefix: Error: ENOENT, build/bin/x64/win32/GalaxyCommunication.exe not found in /nix/store/g87rxkfkfs11r0w7wmsrcdz9hbw1f6nw-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar
    at createError (node:electron/js2c/node_init:2:2060)
    at Object.copyFile (node:electron/js2c/node_init:2:4140)
    at Ts (/nix/store/g87rxkfkfs11r0w7wmsrcdz9hbw1f6nw-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar/build/main/main.js:142:932)
    at Module.Qc [as launch] (/nix/store/g87rxkfkfs11r0w7wmsrcdz9hbw1f6nw-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar/build/main/main.js:16:5680)
    at No (/nix/store/g87rxkfkfs11r0w7wmsrcdz9hbw1f6nw-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar/build/main/main.js:128:1469)
    at Session.<anonymous> (node:electron/js2c/browser_init:2:106823)
(14:54:26) [INFO]:    [Gog]:             Launching Comet!
(14:54:26) [INFO]:    [Gog]:             Launching Quake II: HEROIC_APP_NAME=1947927225 HEROIC_APP_RUNNER=gog GAMEID=umu-0 HEROIC_APP_SOURCE=gog STORE=gog STEAM_COMPAT_INSTALL_PATH="/home/keenan/Games/Heroic/Quake II Enhanced" PULSE_SINK=Game DXIL_SPIRV_CONFIG=wmma_rdna3_workaround LD_PRELOAD= STEAM_COMPAT_CLIENT_INSTALL_PATH=/home/keenan/.local/share/.steam/steam WINEPREFIX="/home/keenan/Games/Heroic/Prefixes/default/Quake II" STEAM_COMPAT_DATA_PATH="/home/keenan/Games/Heroic/Prefixes/default/Quake II" PROTONPATH=/home/keenan/.config/heroic/tools/proton/proton-ge-bin WINE_FULLSCREEN_FSR=0 PROTON_ENABLE_WAYLAND=1 PROTON_ENABLE_HDR=1 PROTON_USE_WOW64=1 PROTON_DISABLE_NVAPI=1 PROTON_EAC_RUNTIME=/home/keenan/.config/heroic/tools/runtimes/eac_runtime PROTON_BATTLEYE_RUNTIME=/home/keenan/.config/heroic/tools/runtimes/battleye_runtime STEAM_COMPAT_APP_ID=0 SteamAppId=0 SteamGameId="heroic-Quake II Enhanced" PROTON_LOG_DIR=/home/keenan/.local/share GOGDL_CONFIG_PATH=/home/keenan/.config/heroic/gogdlConfig /nix/store/g87rxkfkfs11r0w7wmsrcdz9hbw1f6nw-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/keenan/.config/heroic/gog_store/auth.json launch "/home/keenan/Games/Heroic/Quake II Enhanced" 1947927225 --no-wine --wrapper "obs-gamecapture /etc/profiles/per-user/keenan/bin/mangohud --dlsym "/usr/bin/umu-run"" --platform windows
(14:54:26) [DEBUG]:   [Gog]:             Logging to file(s) "/home/keenan/.local/state/Heroic/logs/games/1947927225_gog/launch.log", "/home/keenan/.local/state/Heroic/logs/runners/gog.log"
(14:54:26) [INFO]:    [Backend]:         Preventing display to sleep
(14:54:26) [INFO]:    [Gog]:             Got install info from cache for 1947927225 on windows platform
(14:54:26) [INFO]:    [Gog]:             Got install info from cache for 1947927225 on windows platform
(14:55:36) [INFO]:    [Gog]:             Killing Comet!

GalaxyCommunication.exe isn't in either prefix's C:\ProgramData\GOG.com\Galaxy\redists

`nixpkgs-review` result for #432183

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432183

Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/17024754733

`x86_64-linux`

✅ 3 packages built:

comet-gog_heroic
heroic
heroic-unwrapped

`aarch64-linux`

✅ 1 package built:

comet-gog_heroic

`x86_64-darwin` (sandbox = true)

✅ 1 package built:

comet-gog_heroic

`aarch64-darwin` (sandbox = true)

✅ 1 package built:

comet-gog_heroic

aidalgol · 2025-08-17T20:00:34Z

Getting an error in the logs, but the multiplayer component is still working. (As in, I can see servers and join)

Oops! Let me fix that.

aidalgol · 2025-08-18T21:47:13Z

Turns out not to be a packaging problem. Heroic-Games-Launcher/HeroicGamesLauncher#4885

aidalgol · 2025-08-18T21:56:51Z

@keenanweaver Could you try again with the latest changes?

keenanweaver · 2025-08-18T22:06:53Z

@keenanweaver Could you try again with the latest changes?

Yup, looks good now! It's in ProgramData and launching without error.

(17:03:58) [INFO]:    [Backend]:         Checking if wine version exists: Proton - proton-ge-bin
(17:03:58) [DEBUG]:   [Backend]:         Running Wine command: cmd /c winepath -u C:\ProgramData\GOG.com\Galaxy\redists\GalaxyCommunication.exe
(17:04:00) [INFO]:    [Backend]:         Checking if wine version exists: Proton - proton-ge-bin
(17:04:00) [DEBUG]:   [Backend]:         Running Wine command: sc create GalaxyCommunication binpath=C:\ProgramData\GOG.com\Galaxy\redists\GalaxyCommunication.exe
(17:04:03) [INFO]:    [Gog]:             Launching Comet!
(17:04:03) [INFO]:    [Gog]:             Launching Heretic + Hexen: HEROIC_APP_NAME=1776058590 HEROIC_APP_RUNNER=gog GAMEID=umu-0 HEROIC_APP_SOURCE=gog STORE=gog STEAM_COMPAT_INSTALL_PATH="/home/keenan/Games/Heroic/Heretic + Hexen" PULSE_SINK=Game LD_PRELOAD= STEAM_COMPAT_CLIENT_INSTALL_PATH=/home/keenan/.local/share/.steam/steam WINEPREFIX="/home/keenan/Games/Heroic/Prefixes/default/Heretic  Hexen" STEAM_COMPAT_DATA_PATH="/home/keenan/Games/Heroic/Prefixes/default/Heretic  Hexen" PROTONPATH=/home/keenan/.config/heroic/tools/proton/proton-ge-bin WINE_FULLSCREEN_FSR=0 PROTON_ENABLE_WAYLAND=1 PROTON_ENABLE_HDR=1 PROTON_USE_WOW64=1 PROTON_DISABLE_NVAPI=1 PROTON_EAC_RUNTIME=/home/keenan/.config/heroic/tools/runtimes/eac_runtime PROTON_BATTLEYE_RUNTIME=/home/keenan/.config/heroic/tools/runtimes/battleye_runtime STEAM_COMPAT_APP_ID=0 SteamAppId=0 SteamGameId="heroic-Heretic + Hexen" PROTON_LOG_DIR=/home/keenan/.local/share GOGDL_CONFIG_PATH=/home/keenan/.config/heroic/gogdlConfig /nix/store/9vm867lnr86bsp56islic68i76miplmj-heroic-unwrapped-2.18.1/opt/heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/keenan/.config/heroic/gog_store/auth.json launch "/home/keenan/Games/Heroic/Heretic + Hexen" 1776058590 --no-wine --wrapper "obs-gamecapture /etc/profiles/per-user/keenan/bin/mangohud --dlsym "/usr/bin/umu-run"" --platform windows
(17:04:03) [DEBUG]:   [Gog]:             Logging to file(s) "/home/keenan/.local/state/Heroic/logs/games/1776058590_gog/launch.log", "/home/keenan/.local/state/Heroic/logs/runners/gog.log"
(17:04:03) [INFO]:    [Backend]:         Preventing display to sleep
(17:04:27) [INFO]:    [Gog]:             Killing Comet!

keenanweaver · 2025-08-18T22:15:54Z

Only thing I've noticed off is the libnotify icon not showing:

Flatpak shows the icon + 'Heroic Games Launcher' as the notification title.

I can't remember if the behavior was like the Flatpak in the past.

aidalgol changed the title ~~Heroic win32 helpers fix~~ Add missing Windows Heroic helpers Aug 9, 2025

aidalgol force-pushed the heroic-win32-helpers-fix branch from 7a46b8c to 614a93b Compare August 9, 2025 05:46

aidalgol force-pushed the heroic-win32-helpers-fix branch from 614a93b to 981cd31 Compare August 9, 2025 05:56

nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 9, 2025

keenanweaver suggested changes Aug 9, 2025

View reviewed changes

nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 9, 2025

aidalgol force-pushed the heroic-win32-helpers-fix branch from 981cd31 to c64e5b5 Compare August 9, 2025 21:40

aidalgol requested a review from keenanweaver August 9, 2025 21:40

keenanweaver approved these changes Aug 9, 2025

View reviewed changes

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 9, 2025

CommandMC reviewed Aug 10, 2025

View reviewed changes

pkgs/by-name/he/heroic-unwrapped/package.nix Outdated Show resolved Hide resolved

aidalgol force-pushed the heroic-win32-helpers-fix branch from c64e5b5 to 1c064e7 Compare August 11, 2025 06:39

aidalgol changed the title ~~Add missing Windows Heroic helpers~~ Heroic: fix helper programs Aug 12, 2025

aidalgol requested review from CommandMC and keenanweaver August 12, 2025 06:42

nixpkgs-ci bot removed the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Aug 12, 2025

nix-owners bot requested a review from TomaSajt August 12, 2025 06:48

keenanweaver reviewed Aug 12, 2025

View reviewed changes

keenanweaver approved these changes Aug 12, 2025

View reviewed changes

TomaSajt reviewed Aug 13, 2025

View reviewed changes

pkgs/by-name/co/comet-gog/package.nix Outdated Show resolved Hide resolved

TomaSajt reviewed Aug 13, 2025

View reviewed changes

pkgs/by-name/ga/galaxy-dummy-service_0_2_0/package.nix Outdated Show resolved Hide resolved

aidalgol force-pushed the heroic-win32-helpers-fix branch 2 times, most recently from 0ec29e1 to 83cd05e Compare August 13, 2025 22:12

aidalgol marked this pull request as draft August 16, 2025 02:56

SuperSandro2000 reviewed Aug 16, 2025

View reviewed changes

CommandMC mentioned this pull request Aug 16, 2025

Nix dev shell fix and NixOS README sectionfixes Heroic-Games-Launcher/HeroicGamesLauncher#4866

Open

4 tasks

TomaSajt and others added 6 commits August 17, 2025 13:28

comet-gog_heroic: init at 0.2.0; comet-gog: refactor

bdf3622

comet-gog: add dummy-service passthru

f3e899c

comet-gog: add aidalgol to maintainers

eb430bb

heroic-unwrapped: correct meta.changelog

22acebb

heroic-unwrapped: remove update script

481d9aa

We need to keep the helper programs at the same versions as upstream, so updating just this package is insufficient.

heroic-unwrapped: Add missing dependencies

bf8f6f0

- comet-gog.dummy-service - epic-integration

aidalgol force-pushed the heroic-win32-helpers-fix branch from 83cd05e to 83b1f0c Compare August 17, 2025 03:36

aidalgol marked this pull request as ready for review August 17, 2025 03:37

legendary-heroic: move beside heroic-unwrapped

043ee2d

This is a fork only for Heroic, so move the nix file for this derivation to beside heroic-unwrapped, but expose it as a passthru for ease of overriding.

aidalgol force-pushed the heroic-win32-helpers-fix branch from 83b1f0c to daf1d70 Compare August 17, 2025 03:40

nixpkgs-ci bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Aug 17, 2025

aidalgol requested review from SuperSandro2000, TomaSajt and keenanweaver August 17, 2025 03:50

aidalgol added 2 commits August 19, 2025 09:55

heroic-unwrapped: use correct comet-gog version

6bf6032

heroic-unwrapped: Apply patch for upstream bugfix PR

dae6e7c

aidalgol force-pushed the heroic-win32-helpers-fix branch from daf1d70 to dae6e7c Compare August 18, 2025 21:56

Uh oh!

Heroic: fix helper programs #432183

Are you sure you want to change the base?

Heroic: fix helper programs #432183

Conversation

aidalgol commented Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

keenanweaver left a comment

Choose a reason for hiding this comment

nixpkgs-review result for #432183

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

keenanweaver left a comment

Choose a reason for hiding this comment

nixpkgs-review result for #432183

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

Uh oh!

keenanweaver left a comment

Choose a reason for hiding this comment

nixpkgs-review result for #432183

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

CommandMC commented Aug 12, 2025

Uh oh!

keenanweaver commented Aug 12, 2025

Uh oh!

aidalgol commented Aug 12, 2025

Uh oh!

Uh oh!

TomaSajt Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aidalgol Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TomaSajt commented Aug 15, 2025

Uh oh!

TomaSajt commented Aug 15, 2025

Uh oh!

SuperSandro2000 Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

aidalgol Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

aidalgol commented Aug 17, 2025

Uh oh!

keenanweaver commented Aug 17, 2025

nixpkgs-review result for #432183

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

aidalgol commented Aug 9, 2025 •

edited

Loading

`nixpkgs-review` result for #432183

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)

`nixpkgs-review` result for #432183

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)

`nixpkgs-review` result for #432183

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)

TomaSajt Aug 13, 2025 •

edited

Loading

`nixpkgs-review` result for #432183

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)