huenicorn: init at 1.0.11 #432136
huenicorn: init at 1.0.11 #432136
Conversation
| # builds without these, but cmake complains | ||
| libsysprof-capture | ||
| pcre2 | ||
| util-linux | ||
| libselinux | ||
| libsepol |
There was a problem hiding this comment.
Unsure about this part, should I just leave them in to be sure?
| mkdir $out/bin -p | ||
| cp huenicorn $out/bin | ||
| ''; | ||
|
|
There was a problem hiding this comment.
| passthru.updateScript = nix-update-script { }; | |
There was a problem hiding this comment.
should this be the default for all packages? always explicitly put the (what I figure is the default) update script?
There was a problem hiding this comment.
Depends. For trivial packages you can just use the default nix-update-script. Sometimes you would need to write your own update script. You can grep Nixpkgs to see some examples.
There was a problem hiding this comment.
I know you sometimes need custom update scripts, I was just wondering if (or rather why) it is important to set the default explicitly?
There was a problem hiding this comment.
You don't have to, it's just easier since @r-ryantm can open the package update PR for you automatically if you have update script set up.
There was a problem hiding this comment.
I do know a package I'm maintaining doesn't have the update-script explicitly set and still ryantm does its magic..
See for example #431472.
that's why I was wondering if there is need to set the default one by hand.
There was a problem hiding this comment.
Interesting, I'm also not sure about that.
|
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.