tsduck: 3.40-4165 -> 3.41-4299 #432115
tsduck: 3.40-4165 -> 3.41-4299 #432115
Conversation
bafe016 to
3acb2a1
Compare
|
please check out docs on the correct title conventions (common for both commits and PRs). updates are titled in this format: |
in. - Added environment vars SRT_DONE=1 and RIST_DONE=1 so that scripts/make-config.sh will assume SRT/RIST support. It checks paths for the .h files, but those paths are different on nix.
3acb2a1 to
8409f57
Compare
pkgs/by-name/ts/tsduck/package.nix
Outdated
| ]; | ||
|
|
||
| # remove tests which break the sandbox | ||
| patches = [ ./tests.patch ]; | ||
| checkTarget = "test"; | ||
| doCheck = true; | ||
| doInstallCheck = true; | ||
| doInstallCheck = false; |
There was a problem hiding this comment.
Set this to "false" because in the build it said this step was "skipped" because a target was not set.
|
For the record I've been waiting for merge on this related PR: #416483 ... anything you can do to help build momentum for merging would be appreciated 🙏 +1 for update, if this gets merged first I'll rebase |
|
|
|
|
@siriobalmelli I don't have access to an x86-darwin to try and build it. I'm not sure what the process is and what checks have to pass before things can get merged. I'm hoping to get this merged. |
|
@acid-bong What do I need to do to get this merged? |
pkgs/by-name/ts/tsduck/package.nix
Outdated
| ]; | ||
|
|
||
| # remove tests which break the sandbox | ||
| patches = [ ./tests.patch ]; | ||
| checkTarget = "test"; | ||
| doCheck = true; | ||
| doInstallCheck = true; | ||
| doInstallCheck = false; |
There was a problem hiding this comment.
What's the reason for this? We include udevCheckHook to check the udev rules of the package, but it won't run when we disable the install checks.
There was a problem hiding this comment.
Oh... It just said "installCheck skipped, no target" so I figured I should take it out. I'll add it back in.
|
@ofborg build tsduck |
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.