-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
tutanota-desktop: 277.250414.1 -> 301.250806.1, adopt by s0ssh #432112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
https://github.com/pymitsubishi/homeassistant-mitsubishi/releases/tag/v0.1.5 https://github.com/pymitsubishi/homeassistant-mitsubishi/releases/tag/v0.1.6 https://github.com/pymitsubishi/homeassistant-mitsubishi/releases/tag/v0.1.7 https://github.com/pymitsubishi/homeassistant-mitsubishi/releases/tag/v0.1.8
Understood, thank you for bearing with me, since it's my first time contributing to nixpkgs. I've gone ahead and rebased the parent branch to Let me know if there's anything else I should do for this PR (or look out for in the future). Thanks! =) |
d8a578e
to
d021518
Compare
d021518
to
a8f8a1e
Compare
The tutanote .desktop file doesn't work, it doesn't launch for me for some reason, have to launch it via terminal to actually get to the app. |
Also you should be targeting the master branch, not the nixos release branch unless your doing a backport, which your not since you updating to an even later version on nixos-unstable and also adding yourself as a maintainer. So you should rebase to master and then add the backport: release 25.05 label. |
they can't, they don't have NixOS org membership. only manual backport is the way: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes |
I can add the label for them :3 |
This has been an issue previously, and was not introduced by my contribution. Also forgive the newbie question, but if my goal is to backport this more recent package version onto the stable 25.05 channel, how would I go about doing that properly? |
rebase to master |
a8f8a1e
to
65742b9
Compare
The PR's base branch is set to release-25.05, but 40185 commits from the haskell-updates branch are included. Make sure you know the right base branch for your changes, then:
|
gotta change to branch on github too to master from release-25.05 |
When I try to do this, I'm met with an error:
Clearly I'm doing something wrong, could you help me figure out what that might be? |
@nyabinary Sorry for the ping, just bumping this up! |
|
Yes, I did do this. That's when I'm seeing the aforementioned error message. |
hmm might need to close this PR and then open a new one then |
Will create new PR. Thank you. |
I have updated the package
tutanota-desktop
to the latest stable version, which is necessary due to the previous version available innixos-25.05
being too out-of-date to be supported by tuta, and no longer working.Official changelog here: https://github.com/tutao/tutanota/releases/tag/tutanota-desktop-release-301.250806.1
Things done
passthru.tests
.nixpkgs-review
on this PR. See nixpkgs-review usage../result/bin/
.Add a 👍 reaction to pull requests you find important.