Skip to content

tutanota-desktop: 277.250414.1 -> 301.250806.1, adopt by s0ssh #432112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10,000 commits into from

Conversation

s0ssh
Copy link
Contributor

@s0ssh s0ssh commented Aug 8, 2025

I have updated the package tutanota-desktop to the latest stable version, which is necessary due to the previous version available in nixos-25.05 being too out-of-date to be supported by tuta, and no longer working.

Official changelog here: https://github.com/tutao/tutanota/releases/tag/tutanota-desktop-release-301.250806.1

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

mweinelt added 30 commits August 8, 2025 04:06
@nixpkgs-ci nixpkgs-ci bot closed this Aug 10, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Aug 10, 2025
@s0ssh s0ssh changed the title Update tutanota-desktop tutanota-desktop: 277.250414.1 -> 301.250806.1, adopt by s0ssh Aug 10, 2025
@s0ssh
Copy link
Contributor Author

s0ssh commented Aug 10, 2025

  1. DO NOT target nixos-* branches: they are automatically populated by Hydra. Target master (for new content), release-YY.MM (for backports to stable) or staging/staging-YY.MM (the counterparts of the former two, specifically for mass-rebuild changes).

    1. PR titles adhere to the same conventions as commit titles. Your should be named tutanota-desktop: 277.250414.1 -> 301.250806.1, adopt by s0ssh.

    2. Speaking of adopting while updating: this PR should consist of 3 commits -- version bump > new maintainer entry > add to meta.maintainers (the exact order doesn't matter much, just make sure that the maintainers: add s0ssh should precede tutanota-desktop: add s0ssh to maintainers)

Understood, thank you for bearing with me, since it's my first time contributing to nixpkgs. I've gone ahead and rebased the parent branch to release-25.05, changed the PR title, and split my changes into the commits as you described.

Let me know if there's anything else I should do for this PR (or look out for in the future). Thanks! =)

@s0ssh s0ssh force-pushed the update-tutanota-desktop branch 2 times, most recently from d8a578e to d021518 Compare August 10, 2025 19:11
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 4.workflow: backport This targets a stable branch labels Aug 10, 2025
@s0ssh s0ssh force-pushed the update-tutanota-desktop branch from d021518 to a8f8a1e Compare August 10, 2025 19:19
@nyabinary
Copy link
Contributor

The tutanote .desktop file doesn't work, it doesn't launch for me for some reason, have to launch it via terminal to actually get to the app.

@nyabinary
Copy link
Contributor

Also you should be targeting the master branch, not the nixos release branch unless your doing a backport, which your not since you updating to an even later version on nixos-unstable and also adding yourself as a maintainer. So you should rebase to master and then add the backport: release 25.05 label.

@acid-bong
Copy link
Contributor

add the backport: release 25.05 label

they can't, they don't have NixOS org membership. only manual backport is the way: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes

@nyabinary
Copy link
Contributor

add the backport: release 25.05 label

they can't, they don't have NixOS org membership. only manual backport is the way: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes

I can add the label for them :3

@s0ssh
Copy link
Contributor Author

s0ssh commented Aug 12, 2025

The tutanote .desktop file doesn't work, it doesn't launch for me for some reason, have to launch it via terminal to actually get to the app.

This has been an issue previously, and was not introduced by my contribution. Also forgive the newbie question, but if my goal is to backport this more recent package version onto the stable 25.05 channel, how would I go about doing that properly?

@nyabinary
Copy link
Contributor

The tutanote .desktop file doesn't work, it doesn't launch for me for some reason, have to launch it via terminal to actually get to the app.

This has been an issue previously, and was not introduced by my contribution. Also forgive the newbie question, but if my goal is to backport this more recent package version onto the stable 25.05 channel, how would I go about doing that properly?

rebase to master
I add the flag to backport this to stable
PR gets merged
New PR gets automatically created for a backport to 25.05

@s0ssh s0ssh force-pushed the update-tutanota-desktop branch from a8f8a1e to 65742b9 Compare August 13, 2025 19:22
@nix-owners
Copy link

nix-owners bot commented Aug 13, 2025

The PR's base branch is set to release-25.05, but 40185 commits from the haskell-updates branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the haskell-updates branch, change the base branch to haskell-updates
  • If the changes should go to the release-25.05 branch, rebase your PR onto the merge base with the release-25.05 branch:
    # git rebase --onto $(git merge-base upstream/release-25.05 HEAD) $(git merge-base upstream/haskell-updates HEAD)
    git rebase --onto b965e4c283060415956ccd39eee4ca34a6a56cf8 65742b9d5638798fdc59060801e2d8446dbadce0
    git push --force-with-lease

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 13, 2025
@nyabinary
Copy link
Contributor

gotta change to branch on github too to master from release-25.05

@s0ssh
Copy link
Contributor Author

s0ssh commented Aug 15, 2025

gotta change to branch on github too to master from release-25.05

When I try to do this, I'm met with an error:

There are no new commits between base branch 'master' and head branch 'update-tutanota-desktop'

Clearly I'm doing something wrong, could you help me figure out what that might be?

@s0ssh
Copy link
Contributor Author

s0ssh commented Aug 17, 2025

@nyabinary Sorry for the ping, just bumping this up!

@nyabinary
Copy link
Contributor

gotta change to branch on github too to master from release-25.05

When I try to do this, I'm met with an error:

There are no new commits between base branch 'master' and head branch 'update-tutanota-desktop'

Clearly I'm doing something wrong, could you help me figure out what that might be?

Did you change the branch via Github Web UI?
image
e,g.

@s0ssh
Copy link
Contributor Author

s0ssh commented Aug 18, 2025

gotta change to branch on github too to master from release-25.05

When I try to do this, I'm met with an error:

There are no new commits between base branch 'master' and head branch 'update-tutanota-desktop'

Clearly I'm doing something wrong, could you help me figure out what that might be?

Did you change the branch via Github Web UI? image e,g.

Yes, I did do this. That's when I'm seeing the aforementioned error message.

@nyabinary
Copy link
Contributor

gotta change to branch on github too to master from release-25.05

When I try to do this, I'm met with an error:

There are no new commits between base branch 'master' and head branch 'update-tutanota-desktop'

Clearly I'm doing something wrong, could you help me figure out what that might be?

Did you change the branch via Github Web UI? image e,g.

Yes, I did do this. That's when I'm seeing the aforementioned error message.

hmm might need to close this PR and then open a new one then

@s0ssh
Copy link
Contributor Author

s0ssh commented Aug 20, 2025

Will create new PR. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 4.workflow: backport This targets a stable branch 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.