Skip to content

perl540Packages.DigestHMAC: 1.04 -> 1.05 #432073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

perl540Packages.DigestHMAC: 1.04 -> 1.05 #432073

merged 1 commit into from
Aug 20, 2025

Conversation

aymanbagabas
Copy link
Contributor

@aymanbagabas aymanbagabas commented Aug 8, 2025 •
edited
Loading

Changelog: https://metacpan.org/release/ARODLAND/Digest-HMAC-1.05/source/Changes

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 8, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 8, 2025
@marcusramberg
Copy link
Contributor

Shouldn't this go to staging given the amount of rebuilds?

@NickCao
Copy link
Member

NickCao commented Aug 10, 2025

And please follow the commit message conventions documented in pkgs/README.md

@aymanbagabas aymanbagabas force-pushed the update-perl540Packages.DigestHMAC-1.05 branch from a91fe28 to 6b7d385 Compare August 10, 2025 15:05
@aymanbagabas
Copy link
Contributor Author

And please follow the commit message conventions documented in pkgs/README.md

I've updated the commit message 🙂

@aymanbagabas aymanbagabas force-pushed the update-perl540Packages.DigestHMAC-1.05 branch from 6b7d385 to 30f57ba Compare August 10, 2025 16:05
@nix-owners
Copy link

nix-owners bot commented Aug 10, 2025

The PR's base branch is set to master, but 1721 commits from the python-updates branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the python-updates branch, change the base branch to python-updates
  • If the changes should go to the master branch, rebase your PR onto the merge base with the master branch: 
    # git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/python-updates HEAD)
git rebase --onto 641d909c4a7538f1539da9240dedb1755c907e40 00bc155a5e0a172d779284fa5511dbaec6a1e706
git push --force-with-lease

@aymanbagabas aymanbagabas changed the base branch from master to staging August 10, 2025 16:13
@nixpkgs-ci nixpkgs-ci bot closed this Aug 10, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Aug 10, 2025
@nixpkgs-ci nixpkgs-ci bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 10, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. and removed 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 10, 2025
@aymanbagabas
Copy link
Contributor Author

I've updated the PR to target staging instead of master.

@aymanbagabas aymanbagabas requested a review from de11n August 10, 2025 20:41
@dotlambda dotlambda changed the title Update perl540Packages.DigestHMAC to 1.05 perl540Packages.DigestHMAC: 1.04 -> 1.05 Aug 11, 2025
stigtsp
stigtsp approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@stigtsp stigtsp merged commit 664c5bc into NixOS:staging Aug 20, 2025
48 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@marcusramberg marcusramberg Awaiting requested review from marcusramberg

@zakame zakame Awaiting requested review from zakame

@pSub pSub Awaiting requested review from pSub

@ztzg ztzg Awaiting requested review from ztzg

@qbit qbit Awaiting requested review from qbit

@xworld21 xworld21 Awaiting requested review from xworld21

@invokes-su invokes-su Awaiting requested review from invokes-su

+1 more reviewer

@de11n de11n de11n approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aymanbagabas @marcusramberg @NickCao @stigtsp @de11n