Skip to content

nvs: init at 1.10.6 #432062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

nvs: init at 1.10.6 #432062

merged 2 commits into from
Aug 19, 2025
+56 −0

Conversation

cupcakearmy
Copy link
Contributor

@cupcakearmy cupcakearmy commented Aug 8, 2025 •
edited
Loading

  • added nvs package and myself as maintainer

@nixpkgs-ci nixpkgs-ci bot added 12.first-time contribution This PR is the author's first one; please be gentle! 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Aug 8, 2025
Frontear
Frontear suggested changes Aug 8, 2025
View reviewed changes
Copy link
Member

@Frontear Frontear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also squash your commits and follow the commit naming guidelines.

Additionally, please re-order the commits so adding yourself as a maintainer comes first, otherwise this will cause evaluation failures.

@cupcakearmy
Copy link
Contributor Author

Please also squash your commits and follow the commit naming guidelines.

Additionally, please re-order the commits so adding yourself as a maintainer comes first, otherwise this will cause evaluation failures.

Thanks for the feedback, i've rebased and squashed, hope its correct now :) Also reordered my entry in the maintainers list, since i'm to stupid to alphabeting xD

@cupcakearmy cupcakearmy marked this pull request as ready for review August 8, 2025 19:06
@Frontear
Copy link
Member

Frontear commented Aug 8, 2025

Thanks for the speedy action.

For the commit where you added the package, the convention is to write package name: init at <version>. In your case it would be nvs: init at 1.10.5.

RossSmyth
RossSmyth suggested changes Aug 8, 2025
View reviewed changes
@RossSmyth
Copy link
Contributor

Could you also change the PR name to follow the guidelines?

@cupcakearmy
Copy link
Contributor Author

Could you also change the PR name to follow the guidelines?

@RossSmyth absolutely, can you point me to the guidelines? i scrolled throught the contributing.md but could not find the pull request naming part
Thanks for the other suggestions/improvements! ❤️

@cupcakearmy
Copy link
Contributor Author

@Frontear fixed the commit message. thanks for the feedback!

@cupcakearmy cupcakearmy changed the title add nvs nvs: init at 1.10.5 Aug 8, 2025
RossSmyth
RossSmyth approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@RossSmyth RossSmyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 8, 2025
@cupcakearmy cupcakearmy requested a review from Frontear August 8, 2025 21:01
Frontear
Frontear approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@Frontear Frontear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 8, 2025
Iamanaws
Iamanaws reviewed Aug 9, 2025
View reviewed changes
@cupcakearmy cupcakearmy changed the title nvs: init at 1.10.5 nvs: init at 1.10.6 Aug 9, 2025
@Iamanaws
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432062

Logs: https://github.com/Iamanaws/nixpkgs-review-gha/actions/runs/16855677290

x86_64-linux

✅ 1 package built:
  • nvs

aarch64-linux

✅ 1 package built:
  • nvs

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • nvs
Error logs: `x86_64-darwin`
nvs 
testing.tRunner.func1()
	/nix/store/b72n20ixzl5ja9vciwahkr30bhmsn5jc-go-1.24.5/share/go/src/testing/testing.go:1737 +0x35e
panic({0x20bd8a0?, 0xc0000940b0?})
	/nix/store/b72n20ixzl5ja9vciwahkr30bhmsn5jc-go-1.24.5/share/go/src/runtime/panic.go:792 +0x132
net/http/httptest.newLocalListener()
	/nix/store/b72n20ixzl5ja9vciwahkr30bhmsn5jc-go-1.24.5/share/go/src/net/http/httptest/server.go:71 +0xda
net/http/httptest.NewUnstartedServer(...)
	/nix/store/b72n20ixzl5ja9vciwahkr30bhmsn5jc-go-1.24.5/share/go/src/net/http/httptest/server.go:119
net/http/httptest.NewServer({0x21432e0, 0xc000098090})
	/nix/store/b72n20ixzl5ja9vciwahkr30bhmsn5jc-go-1.24.5/share/go/src/net/http/httptest/server.go:106 +0x25
github.com/y3owk1n/nvs/pkg/installer.newAssetServer(...)
	/nix/build/nix-build-nvs-1.10.6.drv-3065-787422691/source/pkg/installer/installer_test.go:46
github.com/y3owk1n/nvs/pkg/installer.TestDownloadAndInstall_Success_WithChecksum(0xc000082540)
	/nix/build/nix-build-nvs-1.10.6.drv-3065-787422691/source/pkg/installer/installer_test.go:67 +0xd2
testing.tRunner(0xc000082540, 0x213fc50)
	/nix/store/b72n20ixzl5ja9vciwahkr30bhmsn5jc-go-1.24.5/share/go/src/testing/testing.go:1792 +0xf4
created by testing.(*T).Run in goroutine 1
	/nix/store/b72n20ixzl5ja9vciwahkr30bhmsn5jc-go-1.24.5/share/go/src/testing/testing.go:1851 +0x413
FAIL	github.com/y3owk1n/nvs/pkg/installer	0.556s
FAIL

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • nvs
Error logs: `aarch64-darwin`
nvs 
testing.tRunner.func1()
	/nix/store/kw1vd98s15vj700m3gx2x2xca2z477i3-go-1.24.5/share/go/src/testing/testing.go:1737 +0x334
panic({0x102cca780?, 0x140000a2c50?})
	/nix/store/kw1vd98s15vj700m3gx2x2xca2z477i3-go-1.24.5/share/go/src/runtime/panic.go:792 +0x124
net/http/httptest.newLocalListener()
	/nix/store/kw1vd98s15vj700m3gx2x2xca2z477i3-go-1.24.5/share/go/src/net/http/httptest/server.go:71 +0xdc
net/http/httptest.NewUnstartedServer(...)
	/nix/store/kw1vd98s15vj700m3gx2x2xca2z477i3-go-1.24.5/share/go/src/net/http/httptest/server.go:119
net/http/httptest.NewServer({0x102d4ff60, 0x140001769c0})
	/nix/store/kw1vd98s15vj700m3gx2x2xca2z477i3-go-1.24.5/share/go/src/net/http/httptest/server.go:106 +0x28
github.com/y3owk1n/nvs/pkg/installer.newAssetServer(...)
	/nix/build/nix-build-nvs-1.10.6.drv-2520-516201983/source/pkg/installer/installer_test.go:46
github.com/y3owk1n/nvs/pkg/installer.TestDownloadAndInstall_Success_WithChecksum(0x14000082a80)
	/nix/build/nix-build-nvs-1.10.6.drv-2520-516201983/source/pkg/installer/installer_test.go:67 +0xb4
testing.tRunner(0x14000082a80, 0x102d4c8d0)
	/nix/store/kw1vd98s15vj700m3gx2x2xca2z477i3-go-1.24.5/share/go/src/testing/testing.go:1792 +0xe4
created by testing.(*T).Run in goroutine 1
	/nix/store/kw1vd98s15vj700m3gx2x2xca2z477i3-go-1.24.5/share/go/src/testing/testing.go:1851 +0x374
FAIL	github.com/y3owk1n/nvs/pkg/installer	0.021s
FAIL

ghost
ghost reviewed Aug 10, 2025
View reviewed changes
@cupcakearmy
Copy link
Contributor Author

@Iamanaws what should I do do about the tests? the pipelines here seems to pass

@RossSmyth
Copy link
Contributor

My instincts tell me it is __darwinAllowLocalNetworking

Iamanaws
Iamanaws reviewed Aug 12, 2025
View reviewed changes
Iamanaws
Iamanaws approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@Iamanaws Iamanaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result for #432062

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432062

Logs: https://github.com/Iamanaws/nixpkgs-review-gha/actions/runs/17042054883

x86_64-linux

✅ 1 package built:
  • nvs

aarch64-linux

✅ 1 package built:
  • nvs

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • nvs

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • nvs

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Aug 18, 2025
@SigmaSquadron SigmaSquadron merged commit 1f48803 into NixOS:master Aug 19, 2025
27 of 29 checks passed
@SigmaSquadron
Copy link
Contributor

Welcome to Nixpkgs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigmaSquadron SigmaSquadron SigmaSquadron approved these changes

+5 more reviewers

@Frontear Frontear Frontear approved these changes

@y3owk1n y3owk1n y3owk1n left review comments

@RossSmyth RossSmyth RossSmyth approved these changes

@Iamanaws Iamanaws Iamanaws approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cupcakearmy @Frontear @RossSmyth @Iamanaws @SigmaSquadron @y3owk1n