cursor-cli: init at 0-unstable-2025-08-09 #432035
Open
+95
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I was looking into packaging this myself. I think we maybe able to swap out its bundled node for |
|
josh
reviewed
Aug 8, 2025
AndrewBastin
suggested changes
Aug 8, 2025
|
|
Hashes look now look good, but the |
|
I think we should call it "cursor-cli". |
AndrewBastin
suggested changes
Aug 9, 2025
|
I also kinda agree with @aaronjheng, I think it should be called Kinda sucks that they have like 2 different names that they mix around 😅 Also @sudosubin can I raise a PR on your repo to add myself as a maintainer for this package ? |
|
Yes, that's correct. The public name of the package should be |
@AndrewBastin Of course! You're always welcome. |
|
SigmaSquadron
requested changes
Aug 10, 2025
There was a problem hiding this comment.
I am concerned that we are normalising packaging beta-quality leaf software in Nixpkgs. Unless there's a really good reason why this should be urgently packaged, (i.e. it's one of those upstreams that will never declare their software stable) we should wait until the developers state their software is considered ready for general consumption.
|
Please squash the commits. We don't use |
4e02dc1 to
6fd196d
Compare
|
Tested out 6fd196d and it works for me, thanks for packaging! |
Ninja3047
suggested changes
Aug 13, 2025
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
6fd196d to
1f0214d
Compare
|
Tested 1f0214d and working on linux 64 bit. There is a new update that was released yesterday though |
Ninja3047
suggested changes
Aug 17, 2025
Comment on lines
+10
to
+14
| version="0-unstable-$timestamp" | ||
| else | ||
| version="$release" | ||
| fi | ||
|
|
There was a problem hiding this comment.
Suggested change
| version="0-unstable-$timestamp" | |
| else | |
| version="$release" | |
| fi | |
| latestVersion="0-unstable-$timestamp" | |
| else | |
| latestVersion="$release" | |
| fi | |
| currentVersion=$(nix eval --raw -f . cursor-cli.version) | |
| echo "latest version: $latestVersion" | |
| echo "current version: $currentVersion" | |
| if [[ "$latestVersion" == "$currentVersion" ]]; then | |
| echo "package is up-to-date" | |
| exit 0 | |
| fi |
should check if updates are needed first before pre-fetching
Comment on lines
+19
to
+21
| source=$(nix-prefetch-url "$url" --name "cursor-cli-$version") | ||
| hash=$(nix-hash --to-sri --type sha256 "$source") | ||
| update-source-version cursor-cli "$version" "$hash" "$url" --system="$platform" --source-key="sources.$platform" |
There was a problem hiding this comment.
Suggested change
| source=$(nix-prefetch-url "$url" --name "cursor-cli-$version") | |
| hash=$(nix-hash --to-sri --type sha256 "$source") | |
| update-source-version cursor-cli "$version" "$hash" "$url" --system="$platform" --source-key="sources.$platform" | |
| source=$(nix-prefetch-url "$url" --name "cursor-cli-$latestVersion") | |
| hash=$(nix-hash --to-sri --type sha256 "$source") | |
| update-source-version cursor-cli "$latestVersion" "$hash" "$url" --system="$platform" --source-key="sources.$platform" --ignore-same-version |
you need --ignore-same-version, otherwise only the first platform gets updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
cursor-cli, which is currently beta stage.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.