python313Packages.wsgitools: include missing module (fix build) #432011
Conversation
asyncore was removed with the 3.13 release of python. 3.12 still had it, hence we can patch "one version later"
cgi and cgitb were removed with the 3.13 release of python. an (unsupported) replacement is available from pypi
|
| # the built-in asyncore and cgi libraries were removed in python 3.13 | ||
| dependencies = lib.optionals (pythonAtLeast "3.13") [ | ||
| pyasyncore | ||
| legacy-cgi |
There was a problem hiding this comment.
Why do we have both standard-cgi and legacy-cgi, maybe we should drop one of them.
There was a problem hiding this comment.
oh, interesting find! the official docs recommend legacy-cgi but python-deadlib seems to have made its way into nixpkgs as standard-*. I haven't tried it, but switching to standard-cgi might be right "right" thing to do here
There was a problem hiding this comment.
moving everything legacy-cgi -> standard-cgi probably won't be a thing (even if the libraries might technically be compatible / do the same thing) since at least one project explicitly defines a dependency on legacy-cgi: https://github.com/Pylons/webob/blob/main/setup.py#L56-L58 which makes pythonRuntimeDepsCheck fail.
I assume as more people start introducing "compatibility" with 3.13, that's just gonna get more and we'll end up needing both
for wsgitools (this PR), I think it really doesn't matter
|
mostly done in #434173. I guess the incorrect |
cgi and cgitb were removed with the 3.13 release of python. an (unsupported) replacement is available from pypi
also fix the
pythonAtLeastcondition forasyncorewhich was also removed with 3.13 (and not 3.12 like the current default.nix claims)Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.