Skip to content

nixos/matrix-conduit: add secretFile option #432008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

nixos/matrix-conduit: add secretFile option #432008

wants to merge 3 commits into from

Conversation

SchweGELBin
Copy link
Contributor

Conduit doesn't support setting secret files in their settings, but they allow setting environment variables.
To not save the secrets like the turn secret in plain text, I've added a secretFile option, where you can pass a path to the secret file containing all the necessary environment variables.

I've also added myself as a maintainer.
I'm using it in my server and didn't experience any problems.

Have a great day!

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 8, 2025
@SchweGELBin
Copy link
Contributor Author

Hey @wolfgangwalther, I hope it is okay to ping you here.

The current maintainer of this module and the corresponding package is pretty inactive, so I'm pinging you as you are a person who is fairly involved in this module and the corresponding package.

It would be nice if you could review this pull request.
I'm willing to take over the maintainership of this module.

Have a great day!

@wolfgangwalther
Copy link
Contributor

so I'm pinging you as you are a person who is fairly involved in this module and the corresponding package.

Sorry, I am not involved at all. I don't even know what matrix-conduit is, I have never used it or looked at the code more than merging simple version bumps :D

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 18, 2025
@SchweGELBin
Copy link
Contributor Author

SchweGELBin commented Aug 18, 2025 •
edited
Loading

Oh, I'm sorry, thank you anyway!
And thank you for requesting review from other people.

Have a great day!

SuperSandro2000
SuperSandro2000 reviewed Aug 18, 2025
View reviewed changes
@SchweGELBin @SuperSandro2000
nixos/matrix-conduit: improve documentation
72c53ee 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SchweGELBin
Copy link
Contributor Author

SchweGELBin commented Aug 18, 2025 •
edited
Loading

Thank you for your review @SuperSandro2000!
I've implemented all the requested changes.
Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@pstn pstn Awaiting requested review from pstn

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SchweGELBin @wolfgangwalther @SuperSandro2000