Skip to content

bilibili: enable hardware video decode & improve wayland experience. #432832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bilibili: enable hardware video decode & improve wayland experience. #432832

wants to merge 1 commit into from
+3 −1

Conversation

dingdang66686
Copy link
Contributor

To enable vaapi video acceleration.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 11, 2025
@nix-owners nix-owners bot requested review from kashw2, Bot-wxt1221 and Jedsek August 11, 2025 14:48
@Bot-wxt1221
Copy link
Member

will this really work？

kashw2
kashw2 reviewed Aug 12, 2025
View reviewed changes
@Bot-wxt1221
Copy link
Member

This is completely stupid.

msojocs/bilibili-linux#107

@Bot-wxt1221 Bot-wxt1221 reopened this Aug 12, 2025
@dingdang66686
Copy link
Contributor Author

Use this commandLineArg to test out: --enable-features=AcceleratedVideoDecodeLinuxGL, according to ArchWiki, use wayland to get better performance: --ozone-platform=wayland.
image

@Bot-wxt1221
Copy link
Member

So is libva really useful?

@dingdang66686
Copy link
Contributor Author

Run electron chrome://gpu with or without prefix and flags to check if video acceleration working.

@dingdang66686
Copy link
Contributor Author

Without libva no video acceleration information is shown.

@Bot-wxt1221
Copy link
Member

buildInputs is not useful remove it.

Could you add your flags to makeWrapper

Bot-wxt1221
Bot-wxt1221 suggested changes Aug 12, 2025
View reviewed changes
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 12, 2025
SuperSandro2000
SuperSandro2000 reviewed Aug 12, 2025
View reviewed changes
@SuperSandro2000
Copy link
Member

This is completely stupid.

msojocs/bilibili-linux#107

Should we add those as a default?

@Bot-wxt1221
Copy link
Member

Could you please correct the PR name?

@dingdang66686
Copy link
Contributor Author

buildInputs is not useful remove it.

Could you add your flags to makeWrapper

done.

@dingdang66686 dingdang66686 changed the title bilibili: add libva to buildInputs. bilibili: enable hardware video decode & improve wayland experience. Aug 12, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 12, 2025
@GaetanLepage
Copy link
Contributor

Please squash (at least) the two commits related to libva.

@dingdang66686
bilibili: add libva & add default commandLineArgs.
aefe9bd 
- Enable hardware video decode.
- Improve wayland experience.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Jedsek Jedsek Awaiting requested review from Jedsek

+2 more reviewers

@kashw2 kashw2 kashw2 approved these changes

@Bot-wxt1221 Bot-wxt1221 Bot-wxt1221 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dingdang66686 @Bot-wxt1221 @SuperSandro2000 @GaetanLepage @kashw2