Skip to content

wgsl-analyzer: don't build xtask #432821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wgsl-analyzer: don't build xtask #432821

wants to merge 1 commit into from

Conversation

NyCodeGHG
Copy link
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Aug 11, 2025
@nix-owners nix-owners bot requested a review from genga898 August 11, 2025 14:28
@Sigmanificient
Copy link
Member

Sigmanificient commented Aug 11, 2025 •
edited
Loading

Hi @NyCodeGHG! I noticed you’ve opened several PRs related to this topic. Could you share a bit more context on the motivation behind these changes? If it makes sense, maybe we could also open an issue to track them (this way you can reference it and make it easier to review).

@NyCodeGHG
Copy link
Member Author

sure, xtask is a development pattern where cargo workspaces contain a module intended to run arbitrary code used for development (e.g. generation of shell completions or man pages). They are not intended to be used by an end user, so we shouldn't build or install them.

@genga898
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432821

Logs: https://github.com/genga898/nixpkgs-review-gha/actions/runs/16982521109

x86_64-linux

✅ 2 packages built:
  • vscode-extensions.wgsl-analyzer.wgsl-analyzer
  • wgsl-analyzer

aarch64-linux

✅ 2 packages built:
  • vscode-extensions.wgsl-analyzer.wgsl-analyzer
  • wgsl-analyzer

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • vscode-extensions.wgsl-analyzer.wgsl-analyzer
  • wgsl-analyzer

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • vscode-extensions.wgsl-analyzer.wgsl-analyzer
  • wgsl-analyzer

@genga898
Copy link
Contributor

I am not seeing any significant change to be honest, in the build logs, xtask is still being built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genga898 genga898 Awaiting requested review from genga898

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NyCodeGHG @Sigmanificient @genga898