Skip to content

wivrn: 25.6.1 -> 25.8 #432804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2025
Merged

wivrn: 25.6.1 -> 25.8 #432804

merged 2 commits into from
Aug 20, 2025

Conversation

PassiveLemon
Copy link
Contributor

@PassiveLemon PassiveLemon commented Aug 11, 2025 •
edited
Loading

https://github.com/WiVRn/WiVRn/releases/tag/v25.8

Package:

  • New dependency to get Steam game icons
  • Patch (upstream master commit) that allows the in-stream GUI to launch Steam games

Module:

  • Remove the wivrn-application service as now WiVRn starts clients under transient services
  • Option to enable PRESSURE_VESSEL_IMPORT_OPENXR_1_RUNTIMES to allow Steam to automatically discover OpenXR runtimes
  • Re-added the highPriority option (was previously removed to add service hardening)
  • General refactoring to the module

#432695
@ImSapphire

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@PassiveLemon
Copy link
Contributor Author

I have attempted to run nixpkgs-preview but it eats all of my memory and either hangs my machine or gets killed by oomd

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 11, 2025
@nix-owners nix-owners bot requested a review from ImSapphire August 11, 2025 13:38
Scrumplex
Scrumplex reviewed Aug 11, 2025
View reviewed changes
ImSapphire
ImSapphire reviewed Aug 12, 2025
View reviewed changes
nixos/modules/services/video/wivrn.nix
RestrictNamespaces = true;
RestrictSUIDSGID = true;
};
PRESSURE_VESSEL_IMPORT_OPENXR_1_RUNTIMES = mkIf cfg.steam.importOXRRuntimes "1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That variable allows Steam to automatically discover OpenXR runtimes (WiVRn). We add it to the WiVRn service so it knows it's set and won't tell the user to add game launch arguments

Copy link
Contributor

@ImSapphire ImSapphire Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is already set in environment.sessionVariables, wouldn't this propagate to WiVRn itself as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it would be exposed in the service. PATH has to be specified so I assume all other variables do too

@jim3692
Copy link

jim3692 commented Aug 13, 2025

I can confirm that the package works with my Quest 2. I run it like this, so I am not sure about the service part.

nix run --no-write-lock-file github:PassiveLemon/nixpkgs/wivrn-2580#wivrn

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 13, 2025
@ImSapphire ImSapphire requested a review from Scrumplex August 17, 2025 18:05
@tomberek
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432804

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 3 packages built:
  • envision
  • nixpkgs-manual
  • wivrn

@tomberek tomberek merged commit 1c5f0a0 into NixOS:master Aug 20, 2025
27 of 28 checks passed
@NovaViper
Copy link
Contributor

Hey why was services.wivrn.extraPackages removed? Wouldn't removing this result in the NVENC compatibility breaking as it can't find the NVIDIA package (which is what I'm using to ensure it works with NVENC)? 👀

@ImSapphire
Copy link
Contributor

ImSapphire commented Aug 26, 2025 •
edited
Loading

@NovaViper services.wivrn.extraPackages added extra packages to the environment of the wivrn-application service, which was removed. It also has nothing to do with your issue related to NVENC and would not have fixed your issue, just build with pkgs.wivrn.override { cudaSupport = true; }.

@ImSapphire ImSapphire added the backport release-25.05 Backport PR automatically label Aug 29, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 29, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Aug 29, 2025
Open
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Awaiting requested review from Scrumplex

1 more reviewer

@ImSapphire ImSapphire ImSapphire approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PassiveLemon @jim3692 @tomberek @NovaViper @ImSapphire @Scrumplex