Skip to content

gz-cmake: added missing dependencies #432783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gz-cmake: added missing dependencies #432783

wants to merge 1 commit into from

Conversation

Guelakais
Copy link
Contributor

@Guelakais Guelakais commented Aug 11, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 11, 2025
@Guelakais Guelakais self-assigned this Aug 11, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 12, 2025
ethancedwards8
ethancedwards8 suggested changes Aug 12, 2025
View reviewed changes
ethancedwards8
ethancedwards8 suggested changes Aug 12, 2025
View reviewed changes
@Guelakais Guelakais force-pushed the gz-cmake branch 2 times, most recently from 56ec8bc to b9a9e12 Compare August 12, 2025 12:21
@Guelakais
Copy link
Contributor Author

Guelakais commented Aug 12, 2025 •
edited
Loading

Ok, I know, what's going on. I was misleaded. gz-cmake itself isn't the cli tool. It's only a library. gz-toolz is the cli tool! I'm truely Sorry.

@Guelakais Guelakais changed the title gz-cmake: activated cli capabilities gz-cmake: added missing dependencies Aug 12, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5757

@SuperSandroBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432783

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/16923321348

x86_64-linux

✅ 3 packages built:
  • gz-cmake
  • gz-utils
  • gz-utils.doc

aarch64-linux

✅ 3 packages built:
  • gz-cmake
  • gz-utils
  • gz-utils.doc

x86_64-darwin (sandbox = true)

❌ 3 packages failed to build:
  • gz-cmake
  • gz-utils
  • gz-utils.doc
Error logs: `x86_64-darwin`
gz-cmake 
-- Found Python3: /nix/store/9zzyv1p496m8b7j8v3y2dqq1xii9anx5-python3-3.13.5/bin/python3.13 (found version "3.13.5") found components: Interpreter
-- Adding codecheck target
-- Build configuration successful
-- Configuring incomplete, errors occurred!
make[2]: *** [examples/CMakeFiles/gz_conf_RWD.dir/build.make:102: examples/gz_conf_RWD-prefix/src/gz_conf_RWD-stamp/gz_conf_RWD-configure] Error 1
make[1]: *** [CMakeFiles/Makefile2:1591: examples/CMakeFiles/gz_conf_RWD.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
-- Found Python3: /nix/store/9zzyv1p496m8b7j8v3y2dqq1xii9anx5-python3-3.13.5/bin/python3.13 (found version "3.13.5") found components: Interpreter
-- Found Python3: /nix/store/9zzyv1p496m8b7j8v3y2dqq1xii9anx5-python3-3.13.5/bin/python3.13 (found version "3.13.5") found components: Interpreter
-- Adding codecheck target
-- Adding codecheck target
-- Build configuration successful
-- Build configuration successful
-- Configuring incomplete, errors occurred!
-- Configuring incomplete, errors occurred!
make[2]: *** [examples/CMakeFiles/gz_conf_R.dir/build.make:102: examples/gz_conf_R-prefix/src/gz_conf_R-stamp/gz_conf_R-configure] Error 1
make[2]: *** [examples/CMakeFiles/gz_conf_D.dir/build.make:102: examples/gz_conf_D-prefix/src/gz_conf_D-stamp/gz_conf_D-configure] Error 1
make[1]: *** [CMakeFiles/Makefile2:1559: examples/CMakeFiles/gz_conf_R.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:1623: examples/CMakeFiles/gz_conf_D.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

aarch64-darwin (sandbox = true)

✅ 3 packages built:
  • gz-cmake
  • gz-utils
  • gz-utils.doc

@Guelakais Guelakais force-pushed the gz-cmake branch 2 times, most recently from 8d6840f to 1c5fcaa Compare August 13, 2025 09:48
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awwpotato awwpotato Awaiting requested review from awwpotato

@ethancedwards8 ethancedwards8 Awaiting requested review from ethancedwards8

Assignees

@Guelakais Guelakais

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Guelakais @nixos-discourse @SuperSandroBot @ethancedwards8