lasuite-docs: fix mail notifications #432753
Merged
+65
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyouzpanda
reviewed
Aug 12, 2025
cfbf323 to
86f3529
Compare
soyouzpanda
suggested changes
Aug 13, 2025
|
Also, the commit adding mjml-cli must be separated from the commit fixing lasuite-docs. |
The build-process doesn't install the mjml-based mail templates which
results in the following log-lines when trying to invite somebody by
email to collaborate on a document:
Aug 11 08:25:08 lasuite gunicorn[345]: File "/nix/store/4h2z6psmq0nizy39psyf2lil0cqiwl42-python3.13-django-5.2.4/lib/python3.13/site-packages/django/template/loader.py", line 19, in get_template
Aug 11 08:25:08 lasuite gunicorn[345]: raise TemplateDoesNotExist(template_name, chain=chain)
Aug 11 08:25:08 lasuite gunicorn[345]: django.template.exceptions.TemplateDoesNotExist: mail/html/template.html
86f3529 to
5597a4f
Compare
|
Welp, I forgot to remove this, this was a previous attempt to package mjml-cli independently, but gave up. |
ahah, that's what I thought :) |
soyouzpanda
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build-process doesn't install the mjml-based mail templates which results in the following log-lines when trying to invite somebody by email to collaborate on a document:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.