-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
gz-tools: init at 2.0.2 #432725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
gz-tools: init at 2.0.2 #432725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ ./result/bin/gz
I cannot find any available 'gz' command:
* Did you install any Gazebo library?
* Did you set the GZ_CONFIG_PATH environment variable?
E.g.: export GZ_CONFIG_PATH=$HOME/local/share/gz
I guess GZ_CONFIG_PATH
needs to be set?
gc does have a cli tool? I only build them as librarys |
Yes. That's why I used |
Currently all gc packages are built as librarys. They aren't usable as cli tool. |
Then you should probably remove the executable in |
Then my next PR will be to activate the |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to mark x86_64-darwin
as badPlatform
. Other than that, it looks good. Please squash the last commit when you get a chance.
I've just tried rebasing the gz-tools branch over the gz-make branch using the activate CLI tool, and it works too. |
|
What did has failed, in particular? I can't reproduce your failure and would like to solve the bug. |
https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/16884488306/job/47828535150#step:6:611 |
I think, I see, what's the error is. The current |
Maybe, gz-cmake doesn't provide a mainprogram? error: builder for '/nix/store/kmzbxb1y1vympkhg6hqaxzbm7py3nr7y-gz-cmake-4.2.0.drv' failed with exit code 2;
last 25 log lines:
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/GzSanitizers.cmake
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/GzSetCompilerFlags.cmake
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/GzStringAppend.cmake
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/GzUtils.cmake
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/JoinPaths.cmake
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/Export.hh.in
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/cmake_uninstall.cmake.in
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/cpack_options.cmake.in
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/gz-all-config.cmake.in
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/gz-component-config.cmake.in
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/gz-config.cmake.in
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/gz_auto_headers.hh.in
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/upload_doc.sh.in
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/version_info.json.in
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/pkgconfig/gz-component.pc.in
> -- Installing: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/cmake/gz-cmake4/cmake4/pkgconfig/gz.pc.in
> Running phase: fixupPhase
> shrinking RPATHs of ELF executables and libraries in /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0
> checking for references to /build/ in /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0...
> patching script interpreter paths in /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0
> /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/share/gz/gz-cmake4/tools/doc_check.sh: interpreter directive changed from "#!/bin/sh" to "/nix/store/gkwbw9nzbkbz298njbn3577zmrnglbbi-bash-5.3p0/bin/sh"
> stripping (with command strip and flags -S -p) in /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/lib
> Running phase: installCheckPhase
> Executing versionCheckPhase
> versionCheckHook: /nix/store/w635qr3zqsmkjrg5lbnq3maw87zfn04y-gz-cmake-4.2.0/bin/gz was not found, or is not an executable
For full logs, run:
nix log /nix/store/kmzbxb1y1vympkhg6hqaxzbm7py3nr7y-gz-cmake-4.2.0.drv |
I don't think it does. https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/gz/gz-cmake/package.nix#L53 |
|
short reminder: Currently this pr is based on #432783, so you can't merge this pr, because this would automatically merge the commits from the other pr! |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5803 |
Things done
passthru.tests
.nixpkgs-review
on this PR. See nixpkgs-review usage../result/bin/
.Add a 👍 reaction to pull requests you find important.