-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
haskellPackages: fix build of packages maintained by me #432634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Would be nice to have the name
attribute set for fetchpatch so you can roughly tell what the patch does and differentiate the patches easier when e.g. one starts failing to apply.
hash = "sha256-EGFyk3XawU0+zk299WGwFKB2uW9eJrCDM6NgfIKWgRY="; | ||
}) super.proto3-wire; | ||
# QuickCheck <2.15 | ||
# Patching requires signing custom license |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I think I screwed up the phrasing.
Getting PRs merged in the repo is what requires signing a custom license.
See google/proto-lens#494 (comment)
It's not that applying a patch requires a custom license... I think? This is really disruptive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the point here is, that opening an issue certainly does not require accepting that license?
No matter whether via Issue or PR, the ask is to "let upstream know about this".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's what I meant, I saw they want you to sign a CLA and agree this is ridiculous. (For this change, signing an CLA wouldn't even be necessary since it is almost certainly not copyrightable…)
The contribution guidelines even require some kind of that: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#patches
|
Well, I do link to the issue/PR. That gives more context than a fixed comment that might even turn out to be the wrong explanation depending on how the issue/PR evolves. Note that when it comes to the specific concern of knowing at a glance whether a jailbreak/patch can be removed, we have the means to do that automatically, a-la #384591 |
I think giving the patch a name will give better output on the build failure (?), which would be especially relevant for an override with multiple patches. Even the automated script can't tell you which patch should be removed, right? |
Yes, I'm concerned with the build output since comparing sha1 hashes is not fun. |
2b87fc5
to
5c9786f
Compare
Sorry for the delay. Been doing lots of travelling.
Huh good point. It sounds easy enough to build a srcOnly for each patch by removing it, but reporting multiple successes/failures per attribute looks like it's pretty incompatible with the way the script currently works. In the meantime, I added name attributes to each patch, basically taken from the PR titles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM didn't test any builds
|
Things done
passthru.tests
.nixpkgs-review
on this PR. See nixpkgs-review usage../result/bin/
.Add a 👍 reaction to pull requests you find important.