Skip to content

systemdMinimal: fix build #432548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2025
Merged

systemdMinimal: fix build #432548

merged 1 commit into from
Aug 10, 2025

Conversation

LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Aug 10, 2025 •
edited by vcunat
Loading

fixes #418255 / 0afdb39

Remove broken patches. The nspawn conditional can be omitted, as it will not be installed on systemdLibs anyways.

Testing done:

    nix why-depends --precise .#systemdMinimal.out .#getent.out
    /nix/store/x2dhq7nb43xv2c3hh8y7g4bkdzndy7av-systemd-minimal-257.7
    └───bin/systemd-nspawn: …valid, ignoring....../nix/store/h5f0zw8gp3fsrzldsi9x2j29gqz6dv4h-getent-glibc-2.40-66/bin/getent…
        → /nix/store/h5f0zw8gp3fsrzldsi9x2j29gqz6dv4h-getent-glibc-2.40-66

    'git+file:///home/grimmauld/coding/nixpkgs#systemdLibs.out' does not depend on 'git+file:///home/grimmauld/coding/nixpkgs#getent.out'

systemdMinimal, systemdLibs, pam all builds.
pkgsMusl.pam evals successfully.
Currently building systemd.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld
systemdMinimal: fix build
219ca69 
Remove broken patches. The nspawn conditional can be omitted,
as it will not be installed on `systemdLibs` anyways.

Testing done:
```
    nix why-depends --precise .#systemdMinimal.out .#getent.out
    /nix/store/x2dhq7nb43xv2c3hh8y7g4bkdzndy7av-systemd-minimal-257.7
    └───bin/systemd-nspawn: …valid, ignoring....../nix/store/h5f0zw8gp3fsrzldsi9x2j29gqz6dv4h-getent-glibc-2.40-66/bin/getent…
        → /nix/store/h5f0zw8gp3fsrzldsi9x2j29gqz6dv4h-getent-glibc-2.40-66
```

```
    'git+file:///home/grimmauld/coding/nixpkgs#systemdLibs.out' does not depend on 'git+file:///home/grimmauld/coding/nixpkgs#getent.out'
```

`systemdMinimal`, `systemdLibs`, `pam` all builds.
`pkgsMusl.pam` evals successfully.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Aug 10, 2025
@LordGrimmauld
Copy link
Contributor Author

okay, my systemd build just finished successfully. So should be good.

@vcunat vcunat merged commit 3c3c1f5 into NixOS:staging-next Aug 10, 2025
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@ElvishJerricco ElvishJerricco Awaiting requested review from ElvishJerricco

@aanderse aanderse Awaiting requested review from aanderse

@arianvp arianvp Awaiting requested review from arianvp

Assignees
No one assigned
Labels
6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordGrimmauld @vcunat