Skip to content

Sdformat: init at 15.3.0 #432526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sdformat: init at 15.3.0 #432526

wants to merge 3 commits into from

Conversation

Guelakais
Copy link
Contributor

@Guelakais Guelakais commented Aug 10, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium August 10, 2025 13:36
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 10, 2025
@Guelakais Guelakais force-pushed the sdformat branch 2 times, most recently from ea7aa72 to 23738f8 Compare August 10, 2025 13:54
yzhou216
yzhou216 reviewed Aug 11, 2025
View reviewed changes
@Guelakais Guelakais force-pushed the sdformat branch 2 times, most recently from 7581e0c to fe2bb6a Compare August 12, 2025 08:09
yzhou216
yzhou216 reviewed Aug 12, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Aug 13, 2025
@yzhou216
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432526

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/16932394273

x86_64-linux

✅ 7 packages built:
  • gz-cmake
  • gz-math
  • gz-utils
  • gz-utils.doc
  • python312Packages.gz-math (python313Packages.gz-math)
  • python312Packages.gz-math.python (python313Packages.gz-math.python)
  • sdformat

aarch64-linux

✅ 7 packages built:
  • gz-cmake
  • gz-math
  • gz-utils
  • gz-utils.doc
  • python312Packages.gz-math (python313Packages.gz-math)
  • python312Packages.gz-math.python (python313Packages.gz-math.python)
  • sdformat

x86_64-darwin (sandbox = true)

❌ 7 packages failed to build:
  • gz-cmake
  • gz-math
  • gz-utils
  • gz-utils.doc
  • python312Packages.gz-math (python313Packages.gz-math)
  • python312Packages.gz-math.python (python313Packages.gz-math.python)
  • sdformat
Error logs: `x86_64-darwin`
gz-cmake 
-- Found Python3: /nix/store/9zzyv1p496m8b7j8v3y2dqq1xii9anx5-python3-3.13.5/bin/python3.13 (found version "3.13.5") found components: Interpreter
-- Adding codecheck target
-- Build configuration successful
-- Configuring incomplete, errors occurred!
make[2]: *** [examples/CMakeFiles/gz_conf_RWD.dir/build.make:102: examples/gz_conf_RWD-prefix/src/gz_conf_RWD-stamp/gz_conf_RWD-configure] Error 1
make[1]: *** [CMakeFiles/Makefile2:1591: examples/CMakeFiles/gz_conf_RWD.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
-- Found Python3: /nix/store/9zzyv1p496m8b7j8v3y2dqq1xii9anx5-python3-3.13.5/bin/python3.13 (found version "3.13.5") found components: Interpreter
-- Adding codecheck target
-- Build configuration successful
-- Configuring incomplete, errors occurred!
make[2]: *** [examples/CMakeFiles/gz_conf_D.dir/build.make:102: examples/gz_conf_D-prefix/src/gz_conf_D-stamp/gz_conf_D-configure] Error 1
make[1]: *** [CMakeFiles/Makefile2:1623: examples/CMakeFiles/gz_conf_D.dir/all] Error 2
-- Found Python3: /nix/store/9zzyv1p496m8b7j8v3y2dqq1xii9anx5-python3-3.13.5/bin/python3.13 (found version "3.13.5") found components: Interpreter
-- Adding codecheck target
-- Build configuration successful
-- Configuring incomplete, errors occurred!
make[2]: *** [examples/CMakeFiles/gz_conf_R.dir/build.make:102: examples/gz_conf_R-prefix/src/gz_conf_R-stamp/gz_conf_R-configure] Error 1
make[1]: *** [CMakeFiles/Makefile2:1559: examples/CMakeFiles/gz_conf_R.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

aarch64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • python312Packages.gz-math (python313Packages.gz-math)
  • python312Packages.gz-math.python (python313Packages.gz-math.python)
✅ 5 packages built:
  • gz-cmake
  • gz-math
  • gz-utils
  • gz-utils.doc
  • sdformat
Error logs: `aarch64-darwin`
python312Packages.gz-math 
        Start 136: UNIT_Conversions_TEST
134/139 Test #136: UNIT_Conversions_TEST ..................................   Passed    0.01 sec
        Start 137: check_UNIT_Conversions_TEST
135/139 Test #137: check_UNIT_Conversions_TEST ............................   Passed    0.01 sec
        Start 138: UNIT_Util_TEST
136/139 Test #138: UNIT_Util_TEST .........................................   Passed    0.01 sec
        Start 139: check_UNIT_Util_TEST
137/139 Test #139: check_UNIT_Util_TEST ...................................   Passed    0.01 sec
138/139 Test #135: ruby_TEST.rb ...........................................   Passed    0.08 sec
139/139 Test  #93: UNIT_Stopwatch_TEST ....................................   Passed    2.10 sec

99% tests passed, 2 tests failed out of 139


Total Test time (real) =   2.59 sec


The following tests FAILED:

129 - GaussMarkovProcess_TEST.rb (Failed)

130 - Rand_TEST.rb (Failed)

Errors while running CTest

make: *** [Makefile:71: test] Error 8

@yzhou216
Copy link
Contributor

Looks like the Shebangs are not patched properly for cross builds resulting tests failing?

@Guelakais Guelakais moved this to 🔖 Awaits the merge in Ros2 Aug 22, 2025
@Guelakais Guelakais added this to Ros2 Aug 22, 2025
@Guelakais Guelakais moved this from 🔖 Awaits the merge to 👀 Awaits reviews in Ros2 Aug 22, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium Awaiting requested review from natsukium

1 more reviewer

@yzhou216 yzhou216 yzhou216 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
Ros2
Status: 👀 Awaits reviews
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Guelakais @yzhou216 @nixos-discourse