Skip to content

waybar-module-pomodoro: init at 0-unstable-2025-07-28 #432523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

waybar-module-pomodoro: init at 0-unstable-2025-07-28 #432523

wants to merge 1 commit into from

Conversation

Parrot7483
Copy link
Member

@Parrot7483 Parrot7483 commented Aug 10, 2025 •
edited
Loading

This PR adds waybar-module-pomodoro. A pomodoro timer for a system bar.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Parrot7483 Parrot7483 force-pushed the add-waybar-module-pomodoro branch from 9049a4b to 8cc2280 Compare August 10, 2025 13:21
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 10, 2025
@Parrot7483 Parrot7483 added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 10, 2025
acid-bong
acid-bong reviewed Aug 10, 2025
View reviewed changes
@acid-bong
Copy link
Contributor

cc Waybar maintainers for a glance: @FlorianFranzen @lovesegfault @minijackson @rodrgz @Synthetica9 @khaneliman

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 10, 2025
@Parrot7483 Parrot7483 force-pushed the add-waybar-module-pomodoro branch from 8cc2280 to 8d392bc Compare August 11, 2025 08:15
@Parrot7483
Copy link
Member Author

Thank you for your feedback! I applied all requested changes.

acid-bong
acid-bong reviewed Aug 11, 2025
View reviewed changes
@Parrot7483 Parrot7483 force-pushed the add-waybar-module-pomodoro branch from 8d392bc to 21c82ff Compare August 11, 2025 20:47
@khaneliman
Copy link
Contributor

┃ error: hash mismatch in fixed-output derivation '/nix/store/64j507d23cknbsf1dw5dl0j68lfhczbr-source.drv':
┃ specified: sha256-BF7JqDIVDLX66VE/yKmb758rXnfb1rv/4hwzf3i0v5g=
┃ got: sha256-QB/EQlFRyapaqbllun6ttxiYO7/qlAHsVjgKVsHkUTI=

yzhou216
yzhou216 reviewed Aug 11, 2025
View reviewed changes
pkgs/by-name/wa/waybar-module-pomodoro/package.nix
nativeCheckInputs = [
writableTmpDirAsHomeHook
];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add nix-update-script

@wolfgangwalther wolfgangwalther mentioned this pull request Aug 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@yzhou216 yzhou216 yzhou216 left review comments

@acid-bong acid-bong acid-bong left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Parrot7483 @acid-bong @khaneliman @yzhou216