Skip to content

sillytavern: change to global installation #432510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sillytavern: change to global installation #432510

wants to merge 1 commit into from
+7 −13

Conversation

rc-zb
Copy link
Contributor

@rc-zb rc-zb commented Aug 10, 2025 •
edited
Loading

See SillyTavern/SillyTavern#4289 and the official documentation.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@rc-zb rc-zb force-pushed the sillytavern-global-install branch from da28b97 to 00f2b5a Compare August 10, 2025 12:13
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 10, 2025
@nix-owners nix-owners bot requested a review from wrvsrx August 10, 2025 12:19
@rc-zb
Copy link
Contributor Author

rc-zb commented Aug 10, 2025 •
edited
Loading

@wrvsrx #418452 should be adapted to this. The arguments "--dataRoot" and "--configPath" are ignored in global mode, which is forced in global installations. The installation locations also differ.

@rc-zb rc-zb force-pushed the sillytavern-global-install branch 3 times, most recently from 11bef1c to c804c7d Compare August 15, 2025 04:04
@rc-zb rc-zb changed the title sillytavern: support global install and make it default sillytavern: remove makeBinaryWrapper dep, support global install and make it default Aug 15, 2025
@rc-zb rc-zb force-pushed the sillytavern-global-install branch from c804c7d to ae39c2a Compare August 15, 2025 04:21
wrvsrx
wrvsrx suggested changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@wrvsrx wrvsrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we can just use XDG_DATA_HOME to change data dir in global installation mode. Can we simply remove the globalInstall option and make global installation the only mode available?

@rc-zb
Copy link
Contributor Author

rc-zb commented Aug 16, 2025

Yes, we can. The standalone mode is very conter-intuitive to me (see SillyTavern/SillyTavern#4209). I just worry about the existing uses. But the package has not been backported into a stable branch, so such a change does little harm, I guess.

@rc-zb rc-zb force-pushed the sillytavern-global-install branch from ae39c2a to 41613e7 Compare August 16, 2025 04:27
@rc-zb rc-zb changed the title sillytavern: remove makeBinaryWrapper dep, support global install and make it default sillytavern: change to global installation Aug 16, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 16, 2025
@wrvsrx
Copy link
Contributor

wrvsrx commented Aug 16, 2025

I'll update #418452 later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@wrvsrx wrvsrx wrvsrx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rc-zb @wrvsrx