Skip to content

dartsim: clean #432498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2025
Merged

dartsim: clean #432498

merged 2 commits into from
Aug 25, 2025

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Aug 10, 2025 •
edited
Loading

I once again needed dartsim, so I once again packaged it, forgetting that I already finished that in #375590…
I guess I was left too much under the sun without proper supervision. Sorry.

Anyways, this is a bit cleaner now.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Aug 10, 2025
@nim65s nim65s marked this pull request as ready for review August 18, 2025 19:09
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 18, 2025
pbsds
pbsds reviewed Aug 20, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 20, 2025
@pbsbot
Copy link

pbsbot commented Aug 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432498
Commit: 321ec8426d2f273b1f728dbc557d5b4ab81aec4a

x86_64-linux

✅ 3 packages built:
  • dartsim
  • python312Packages.dartsim
  • python313Packages.dartsim

@pbsds pbsds merged commit e9ec3bd into NixOS:master Aug 25, 2025
25 of 27 checks passed
@nim65s nim65s deleted the dartsim branch August 25, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbsds pbsds pbsds left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nim65s @pbsbot @pbsds