Skip to content

Conversation

dsg22
Copy link
Contributor

@dsg22 dsg22 commented Aug 10, 2025

This enables using the Ceph FSAL to serve files from CephFS. Also enable DBus.

Testing was done against nixpkgs-25.05 using callPackage due to breakage on unstable, but I don't think it matters here.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 10, 2025
@nix-owners nix-owners bot requested a review from markuskowa August 10, 2025 10:46
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ceph is currently broken on master (i.e. arrow-cpp is actually broken).

@dsg22
Copy link
Contributor Author

dsg22 commented Aug 14, 2025

Yeah, I noticed the ceph build breakage. I tested this by using the module from master on 25.05. Sorry, should have mentioned that.

It turns out my project won't end up using nfs-ganesha after all, so I don't have a need for this functionality anymore. I'll still try to update the PR to make the ceph dependency optional when I have some free time. Thanks for taking the time to look at it.

@dsg22 dsg22 force-pushed the feature-nfs-ganesha-ceph branch 2 times, most recently from 7c1b6d1 to cdf3e9b Compare August 29, 2025 20:39
@dsg22
Copy link
Contributor Author

dsg22 commented Aug 29, 2025

Turns out I do need nfs-ganesha after all :)

I updated the Ceph changes to make them optional and also updated to build other Ceph features like the rados_ng recovery backend.

Since I was working on this, I also made two unrelated changes - one is to bump the nfs-ganesha version to the new 7.0 release, and the other is to enable DBus (can be used for runtime management and to collect service metrics). I figured it would be easier to have all three in the same PR, but if you prefer I can open separate PRs for those. They are all self-contained in their own commits.

The build patch for DBus is a bit ugly, but I just could not get cmake to pick up the DBus headers and libs through pkg-config.

@dsg22 dsg22 changed the title nfs-ganesha: Build with Ceph support nfs-ganesha: Build with Ceph and DBus support, bump version to v7.0 Aug 29, 2025
@dsg22 dsg22 requested a review from markuskowa August 29, 2025 20:47
@dsg22 dsg22 force-pushed the feature-nfs-ganesha-ceph branch from cdf3e9b to 14a187d Compare August 29, 2025 20:58
@dsg22 dsg22 changed the title nfs-ganesha: Build with Ceph and DBus support, bump version to v7.0 nfs-ganesha: Build with Ceph and DBus support Aug 29, 2025
@dsg22
Copy link
Contributor Author

dsg22 commented Aug 29, 2025

I pulled the v7.0 patch, I'll submit that as a separate PR. Sorry for the churn.

@dsg22
Copy link
Contributor Author

dsg22 commented Aug 29, 2025

Okay, the v7.0 patch is ready. Needed to upgrade ntirpc as well. I added it to this PR, but let me know if you prefer me to split them up.

I also tested this on nixpkgs master, since the build failures seem to be fixed now. NFS serving works, no problems observed.

@nixpkgs-ci nixpkgs-ci bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Aug 29, 2025
@dsg22 dsg22 force-pushed the feature-nfs-ganesha-ceph branch from b8b88b6 to b5cfd98 Compare August 30, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants