Skip to content

goose-cli: 1.0.30 -> 1.4.0 #432465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

goose-cli: 1.0.30 -> 1.4.0 #432465

merged 1 commit into from
Aug 20, 2025

Conversation

Tyler-Hardin
Copy link
Contributor

@Tyler-Hardin Tyler-Hardin commented Aug 10, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 10, 2025
@nix-owners nix-owners bot requested a review from cloudripper August 10, 2025 19:43
@illustris
Copy link
Contributor

Hey, can you please bump the version to 1.4.0?

@Tyler-Hardin
Copy link
Contributor Author

Tyler-Hardin commented Aug 18, 2025 •
edited
Loading

They release a new version roughly every week. I have to wait roughly a week for each change I push to be tested on darwin. At some point, we need to just release the current version and make a new PR.

@Tyler-Hardin
Copy link
Contributor Author

Oh, just noticed the darwin test failed anyway. Going to fix those and go ahead and bump the version while I'm at it.

@Tyler-Hardin Tyler-Hardin changed the title goose-cli: 1.0.30 -> 1.2.0 goose-cli: 1.0.30 -> 1.4.0 Aug 18, 2025
@yzx9
Copy link
Contributor

yzx9 commented Aug 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432465
Commit: c58f8542c19d7686fb24fb352c00e8c6f376a438

x86_64-linux

✅ 1 package built:
  • goose-cli

aarch64-darwin

✅ 1 package built:
  • goose-cli

yzx9
yzx9 approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@yzx9 yzx9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 19, 2025
illustris
illustris approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@illustris illustris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No point in waiting for ofborg to build on darwin if yzx9 already built it on darwin. I've built and tested on x86_64-linux, lgtm.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 19, 2025
@pbsds pbsds merged commit f826251 into NixOS:master Aug 20, 2025
29 of 31 checks passed
@yzx9 yzx9 mentioned this pull request Aug 24, 2025
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudripper cloudripper Awaiting requested review from cloudripper

2 more reviewers

@illustris illustris illustris approved these changes

@yzx9 yzx9 yzx9 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tyler-Hardin @illustris @yzx9 @pbsds