Skip to content

python313Packages.osrf-pycommon: init at 2.1.7 #432464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

python313Packages.osrf-pycommon: init at 2.1.7 #432464

wants to merge 1 commit into from

Conversation

Guelakais
Copy link
Contributor

@Guelakais Guelakais commented Aug 10, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium August 10, 2025 08:55
@Guelakais Guelakais force-pushed the osrf-pycommon branch 2 times, most recently from d83ca0f to 1aa39e8 Compare August 10, 2025 09:15
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 10, 2025
@acid-bong
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432464

Logs: https://github.com/acid-bong/nixpkgs-review-gha/actions/runs/16860730692

x86_64-linux

✅ 4 packages built:
  • python312Packages.osrf-pycommon
  • python312Packages.osrf-pycommon.dist
  • python313Packages.osrf-pycommon
  • python313Packages.osrf-pycommon.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.osrf-pycommon
  • python312Packages.osrf-pycommon.dist
  • python313Packages.osrf-pycommon
  • python313Packages.osrf-pycommon.dist

x86_64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.osrf-pycommon
  • python312Packages.osrf-pycommon.dist
  • python313Packages.osrf-pycommon
  • python313Packages.osrf-pycommon.dist

aarch64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.osrf-pycommon
  • python312Packages.osrf-pycommon.dist
  • python313Packages.osrf-pycommon
  • python313Packages.osrf-pycommon.dist

acid-bong
acid-bong approved these changes Aug 10, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 10, 2025
@Guelakais
Copy link
Contributor Author

Approved automatically following the successful run of nixpkgs-review.

This was fast. Thanks

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 10, 2025
fabaff
fabaff reviewed Aug 13, 2025
View reviewed changes
@Guelakais Guelakais moved this to 🔖 Awaits the merge in Ros2 Aug 22, 2025
@Guelakais Guelakais added this to Ros2 Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff left review comments

@Sigmanificient Sigmanificient Sigmanificient approved these changes

@natsukium natsukium Awaiting requested review from natsukium

+1 more reviewer

@acid-bong acid-bong acid-bong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
Ros2
Status: 🔖 Awaits the merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Guelakais @acid-bong @fabaff @Sigmanificient